This revision was automatically updated to reflect the committed changes.
Closed by commit R310:18a2371fe394: [NestedListHelper] Improve indentation code
(authored by poboiko).
REPOSITORY
R310 KTextWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29208?vs=81738=81743
REVISION
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R310 KTextWidgets
BRANCH
unused (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29208
To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack,
poboiko updated this revision to Diff 81738.
poboiko added a comment.
Improve readability as suggested, also const'ify
REPOSITORY
R310 KTextWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29208?vs=81256=81738
BRANCH
unused (branched from master)
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> poboiko wrote in nestedlisthelper.cpp:87
> That's the current block being checked, not the next one. I've just checked
> to be sure, last block can be unindented :)
>
> TBH, I don't really know if it's even possible for the current block to be
>
poboiko added inline comments.
INLINE COMMENTS
> dfaure wrote in nestedlisthelper.cpp:87
> So the last block cannot be unindented? How come?
That's the current block being checked, not the next one. I've just checked to
be sure, last block can be unindented :)
TBH, I don't really know if it's
dfaure added inline comments.
INLINE COMMENTS
> nestedlisthelper.cpp:87
> +QTextBlock nextBlock = block.next();
> +if (!block.isValid()) {
> +return false;
So the last block cannot be unindented? How come?
REPOSITORY
R310 KTextWidgets
REVISION DETAIL
poboiko created this revision.
poboiko added reviewers: Frameworks, dfaure, mlaurent.
Herald added a project: Frameworks.
poboiko requested review of this revision.
REVISION SUMMARY
The patch includes following improvements:
1. `handleAfterKeyPressEvent` was only used to adjust margins. We
