mart updated this revision to Diff 83090.
mart added a comment.
- update to new colors
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29232?vs=81363&id=83090
BRANCH
arcpatch-D29232
REVISION DETAIL
https://phabricator.kde.org/D29232
AFFECTED FI
ndavis added a comment.
Suggested colors are based on
https://invent.kde.org/plasma/breeze/-/merge_requests/2
INLINE COMMENTS
> kcolorscheme.cpp:258
> +static const SetDefaultColors defaultHeaderColors = {
> +{ 49, 54, 59 }, // Background
> +{ 59, 64, 69 }, // Alternate
` 227,
mart added inline comments.
INLINE COMMENTS
> davidre wrote in kcolorscheme.cpp:271
> Because the new colors are the replacement for theses colors. I thought one
> of those might map to this
i also added a question on the task, whether final colors are decided for it,
they should go up here
ht
davidre added inline comments.
INLINE COMMENTS
> ndavis wrote in kcolorscheme.cpp:271
> Why is that? The only one that might is Active, but that's not really used
> much right now.
Because the new colors are the replacement for theses colors. I thought one of
those might map to this
REPOSITOR
ndavis added inline comments.
INLINE COMMENTS
> davidre wrote in kcolorscheme.cpp:271
> I would have expected at least of one the new colors to have the same value
> as this one.
Why is that? The only one that might is Active, but that's not really used much
right now.
REPOSITORY
R265 KConf
davidre added inline comments.
INLINE COMMENTS
> kcolorscheme.cpp:271
> static const DecoDefaultColors defaultDecorationColors = {
> { 61, 174, 233 }, // Focus
> { 147, 206, 233 }, // Hover
I would have expected at least of one the new colors to have the same value as
this one.
REP
cblack added inline comments.
INLINE COMMENTS
> ndavis wrote in kcolorscheme.h:133
> I think it would be good to explain the issue about enums being converted
> into plain integers here so that people know why they shouldn't depend on it.
> Also, is there a way to hide this from the api.kde.org
mart requested review of this revision.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D29232
To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
mart retitled this revision from "[WIP][RFC]Introduce the Tools color set" to
"[WIP][RFC]Introduce the Header color set".
mart edited the summary of this revision.
mart edited the test plan for this revision.
REPOSITORY
R265 KConfigWidgets
BRANCH
phab/toolsSet
REVISION DETAIL
https://phab
