D29278: Port KWin to KWaylandServer
This revision was automatically updated to reflect the committed changes. Closed by commit R108:3a9d7a6e9d75: Port KWin to KWaylandServer (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29278?vs=81574=81575#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29278?vs=81574=81575 REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h abstract_output.cpp abstract_output.h abstract_wayland_output.cpp abstract_wayland_output.h autotests/CMakeLists.txt autotests/integration/dont_crash_cursor_physical_size_empty.cpp autotests/integration/globalshortcuts_test.cpp autotests/integration/idle_inhibition_test.cpp autotests/integration/input_stacking_order.cpp autotests/integration/internal_window.cpp autotests/integration/lockscreen.cpp autotests/integration/maximize_test.cpp autotests/integration/plasmawindow_test.cpp autotests/integration/pointer_constraints_test.cpp autotests/integration/pointer_input.cpp autotests/integration/scene_opengl_shadow_test.cpp autotests/integration/scene_qpainter_shadow_test.cpp autotests/integration/scene_qpainter_test.cpp autotests/integration/test_helpers.cpp autotests/integration/transient_placement.cpp autotests/integration/xdgshellclient_test.cpp autotests/integration/xwayland_input_test.cpp autotests/integration/xwayland_selections_test.cpp autotests/mock_effectshandler.h autotests/test_window_paint_data.cpp composite.cpp debug_console.cpp decorations/decorationbridge.cpp effects.cpp effects.h effects/backgroundcontrast/contrast.cpp effects/backgroundcontrast/contrast.h effects/blur/blur.cpp effects/blur/blur.h effects/desktopgrid/desktopgrid.cpp effects/slidingpopups/slidingpopups.cpp events.cpp idle_inhibition.cpp idle_inhibition.h input.cpp keyboard_input.cpp keyboard_repeat.cpp libkwineffects/CMakeLists.txt libkwineffects/kwineffects.cpp libkwineffects/kwineffects.h linux_dmabuf.cpp linux_dmabuf.h main.cpp main_wayland.cpp platform.cpp platform.h platformsupport/scenes/opengl/CMakeLists.txt platformsupport/scenes/opengl/abstract_egl_backend.cpp platformsupport/scenes/opengl/abstract_egl_backend.h platformsupport/scenes/opengl/egl_dmabuf.cpp platformsupport/scenes/opengl/egl_dmabuf.h plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_inputeventfilter.cpp plugins/platforms/drm/drm_output.cpp plugins/platforms/drm/drm_output.h plugins/platforms/drm/egl_stream_backend.cpp plugins/platforms/drm/egl_stream_backend.h plugins/platforms/drm/remoteaccess_manager.cpp plugins/platforms/drm/remoteaccess_manager.h plugins/platforms/fbdev/fb_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.h plugins/platforms/virtual/virtual_backend.cpp plugins/platforms/virtual/virtual_output.cpp plugins/platforms/wayland/egl_wayland_backend.cpp plugins/platforms/wayland/wayland_backend.cpp plugins/platforms/wayland/wayland_output.cpp plugins/platforms/x11/windowed/x11windowed_backend.cpp plugins/platforms/x11/windowed/x11windowed_output.cpp plugins/scenes/opengl/scene_opengl.cpp plugins/scenes/opengl/scene_opengl.h plugins/scenes/qpainter/scene_qpainter.cpp plugins/scenes/qpainter/scene_qpainter.h pointer_input.cpp pointer_input.h scene.cpp scene.h shadow.cpp shadow.h tablet_input.cpp toplevel.cpp toplevel.h touch_input.cpp virtualdesktops.cpp virtualdesktops.h virtualkeyboard.cpp wayland_cursor_theme.cpp wayland_server.cpp wayland_server.h xdgshellclient.cpp xdgshellclient.h xkb.cpp xkb.h xwl/clipboard.cpp xwl/clipboard.h xwl/databridge.cpp xwl/databridge.h xwl/dnd.cpp xwl/dnd.h xwl/drag_wl.cpp xwl/drag_wl.h xwl/drag_x.cpp xwl/drag_x.h xwl/selection_source.cpp xwl/selection_source.h xwl/transfer.cpp xwl/transfer.h To: apol, #kwin, #plasma, #frameworks, davidedmundson, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
zzag accepted this revision. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
apol updated this revision to Diff 81574. apol added a comment. Address @zzag's comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29278?vs=81521=81574 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h abstract_output.cpp abstract_output.h abstract_wayland_output.cpp abstract_wayland_output.h autotests/CMakeLists.txt autotests/integration/dont_crash_cursor_physical_size_empty.cpp autotests/integration/globalshortcuts_test.cpp autotests/integration/idle_inhibition_test.cpp autotests/integration/input_stacking_order.cpp autotests/integration/internal_window.cpp autotests/integration/lockscreen.cpp autotests/integration/maximize_test.cpp autotests/integration/plasmawindow_test.cpp autotests/integration/pointer_constraints_test.cpp autotests/integration/pointer_input.cpp autotests/integration/scene_opengl_shadow_test.cpp autotests/integration/scene_qpainter_shadow_test.cpp autotests/integration/scene_qpainter_test.cpp autotests/integration/test_helpers.cpp autotests/integration/transient_placement.cpp autotests/integration/xdgshellclient_test.cpp autotests/integration/xwayland_input_test.cpp autotests/integration/xwayland_selections_test.cpp autotests/mock_effectshandler.h autotests/test_window_paint_data.cpp composite.cpp debug_console.cpp decorations/decorationbridge.cpp effects.cpp effects.h effects/backgroundcontrast/contrast.cpp effects/backgroundcontrast/contrast.h effects/blur/blur.cpp effects/blur/blur.h effects/desktopgrid/desktopgrid.cpp effects/slidingpopups/slidingpopups.cpp events.cpp idle_inhibition.cpp idle_inhibition.h input.cpp keyboard_input.cpp keyboard_repeat.cpp libkwineffects/CMakeLists.txt libkwineffects/kwineffects.cpp libkwineffects/kwineffects.h linux_dmabuf.cpp linux_dmabuf.h main.cpp main_wayland.cpp platform.cpp platform.h platformsupport/scenes/opengl/CMakeLists.txt platformsupport/scenes/opengl/abstract_egl_backend.cpp platformsupport/scenes/opengl/abstract_egl_backend.h platformsupport/scenes/opengl/egl_dmabuf.cpp platformsupport/scenes/opengl/egl_dmabuf.h plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_inputeventfilter.cpp plugins/platforms/drm/drm_output.cpp plugins/platforms/drm/drm_output.h plugins/platforms/drm/egl_stream_backend.cpp plugins/platforms/drm/egl_stream_backend.h plugins/platforms/drm/remoteaccess_manager.cpp plugins/platforms/drm/remoteaccess_manager.h plugins/platforms/fbdev/fb_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.h plugins/platforms/virtual/virtual_backend.cpp plugins/platforms/virtual/virtual_output.cpp plugins/platforms/wayland/egl_wayland_backend.cpp plugins/platforms/wayland/wayland_backend.cpp plugins/platforms/wayland/wayland_output.cpp plugins/platforms/x11/windowed/x11windowed_backend.cpp plugins/platforms/x11/windowed/x11windowed_output.cpp plugins/scenes/opengl/scene_opengl.cpp plugins/scenes/opengl/scene_opengl.h plugins/scenes/qpainter/scene_qpainter.cpp plugins/scenes/qpainter/scene_qpainter.h pointer_input.cpp pointer_input.h scene.cpp scene.h shadow.cpp shadow.h tablet_input.cpp toplevel.cpp toplevel.h touch_input.cpp virtualdesktops.cpp virtualdesktops.h virtualkeyboard.cpp wayland_cursor_theme.cpp wayland_server.cpp wayland_server.h xdgshellclient.cpp xdgshellclient.h xkb.cpp xkb.h xwl/clipboard.cpp xwl/clipboard.h xwl/databridge.cpp xwl/databridge.h xwl/dnd.cpp xwl/dnd.h xwl/drag_wl.cpp xwl/drag_wl.h xwl/drag_x.cpp xwl/drag_x.h xwl/selection_source.cpp xwl/selection_source.h xwl/transfer.cpp xwl/transfer.h To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
apol marked an inline comment as done. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
davidedmundson added a comment. > Hmm, I can't build kwin Hit the same thing, we've since fixed that (patch in kwayland-server) REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
zzag added a comment.
Hmm, I can't build kwin
/home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.cpp:44:10:
fatal error: KWaylandServer/surface_interface.h: No such file or directory
44 | #include
| ^~~~
compilation terminated.
INLINE COMMENTS
> CMakeLists.txt:131
> +TYPE REQUIRED
> +PURPOSE "For screenlocker integration in kwin_wayland"
> +)
Well, we need it to make the wayland session work.
> CMakeLists.txt:644
> KF5::WaylandClient
> -KF5::WaylandServer
> +Plasma::KWaylandServer
> Wayland::Cursor
I feel like it should be KWaylandServer::KWaylandServer but we can revisit it.
> kwineffects.h:68
>
> -namespace KWayland {
> -namespace Server {
> -class SurfaceInterface;
> -class Display;
> -}
> +namespace KWaylandServer {
> +class SurfaceInterface;
This breaks source compatibility, but I guess we don't have a choice.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29278
To: apol, #kwin, #plasma, #frameworks
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk,
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening,
romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29278: Port KWin to KWaylandServer
apol created this revision. apol added reviewers: KWin, Plasma, Frameworks. Herald added a project: KWin. Herald added a subscriber: kwin. apol requested review of this revision. REVISION SUMMARY Away from KWayland::Server and KF5WaylandServer. TEST PLAN Builds, ran nested session REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES CMakeLists.txt abstract_client.cpp abstract_client.h abstract_output.cpp abstract_output.h abstract_wayland_output.cpp abstract_wayland_output.h autotests/CMakeLists.txt autotests/integration/dont_crash_cursor_physical_size_empty.cpp autotests/integration/globalshortcuts_test.cpp autotests/integration/idle_inhibition_test.cpp autotests/integration/input_stacking_order.cpp autotests/integration/internal_window.cpp autotests/integration/lockscreen.cpp autotests/integration/maximize_test.cpp autotests/integration/plasmawindow_test.cpp autotests/integration/pointer_constraints_test.cpp autotests/integration/pointer_input.cpp autotests/integration/scene_opengl_shadow_test.cpp autotests/integration/scene_qpainter_shadow_test.cpp autotests/integration/scene_qpainter_test.cpp autotests/integration/test_helpers.cpp autotests/integration/transient_placement.cpp autotests/integration/xdgshellclient_test.cpp autotests/integration/xwayland_input_test.cpp autotests/integration/xwayland_selections_test.cpp autotests/mock_effectshandler.h autotests/test_window_paint_data.cpp composite.cpp debug_console.cpp decorations/decorationbridge.cpp effects.cpp effects.h effects/backgroundcontrast/contrast.cpp effects/backgroundcontrast/contrast.h effects/blur/blur.cpp effects/blur/blur.h effects/desktopgrid/desktopgrid.cpp effects/slidingpopups/slidingpopups.cpp events.cpp idle_inhibition.cpp idle_inhibition.h input.cpp keyboard_input.cpp keyboard_repeat.cpp libkwineffects/CMakeLists.txt libkwineffects/kwineffects.cpp libkwineffects/kwineffects.h linux_dmabuf.cpp linux_dmabuf.h main.cpp main_wayland.cpp platform.cpp platform.h platformsupport/scenes/opengl/CMakeLists.txt platformsupport/scenes/opengl/abstract_egl_backend.cpp platformsupport/scenes/opengl/abstract_egl_backend.h platformsupport/scenes/opengl/egl_dmabuf.cpp platformsupport/scenes/opengl/egl_dmabuf.h plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_inputeventfilter.cpp plugins/platforms/drm/drm_output.cpp plugins/platforms/drm/drm_output.h plugins/platforms/drm/egl_stream_backend.cpp plugins/platforms/drm/egl_stream_backend.h plugins/platforms/drm/remoteaccess_manager.cpp plugins/platforms/drm/remoteaccess_manager.h plugins/platforms/fbdev/fb_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.cpp plugins/platforms/hwcomposer/hwcomposer_backend.h plugins/platforms/virtual/virtual_backend.cpp plugins/platforms/virtual/virtual_output.cpp plugins/platforms/wayland/egl_wayland_backend.cpp plugins/platforms/wayland/wayland_backend.cpp plugins/platforms/wayland/wayland_output.cpp plugins/platforms/x11/windowed/x11windowed_backend.cpp plugins/platforms/x11/windowed/x11windowed_output.cpp plugins/scenes/opengl/scene_opengl.cpp plugins/scenes/opengl/scene_opengl.h plugins/scenes/qpainter/scene_qpainter.cpp plugins/scenes/qpainter/scene_qpainter.h pointer_input.cpp pointer_input.h scene.cpp scene.h shadow.cpp shadow.h tablet_input.cpp toplevel.cpp toplevel.h touch_input.cpp virtualdesktops.cpp virtualdesktops.h virtualkeyboard.cpp wayland_cursor_theme.cpp wayland_server.cpp wayland_server.h xdgshellclient.cpp xdgshellclient.h xkb.cpp xkb.h xwl/clipboard.cpp xwl/clipboard.h xwl/databridge.cpp xwl/databridge.h xwl/dnd.cpp xwl/dnd.h xwl/drag_wl.cpp xwl/drag_wl.h xwl/drag_x.cpp xwl/drag_x.h xwl/selection_source.cpp xwl/selection_source.h xwl/transfer.cpp xwl/transfer.h To: apol, #kwin, #plasma, #frameworks Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
