D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#676448 , @dfaure wrote: > When you wrote "ki18n_install() is basically used by KF sources that use ECM already" it seemed to me that this was looking at KDE community code only FWIW, I also checked

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. In D29299#676447 , @pino wrote: > In D29299#676446 , @dfaure wrote: > > > In D29299#676445 , @pino wrote: > > > > > > > > >

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#676446 , @dfaure wrote: > In D29299#676445 , @pino wrote: > > > I asked for actual **valid** use cases when using the new variables first would break, and I still got

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. In D29299#676445 , @pino wrote: > I asked for actual **valid** use cases when using the new variables first would break, and I still got none. There is a limit to how much you can keep broken code working... assuming

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#676439 , @dfaure wrote: > @pino Other than the fact that you think D29136 is "good enough", do you have any concrete objection to this version? I think I already wrote

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. @pino Other than the fact that you think D29136 is "good enough", do you have any concrete objection to this version? My own objection would simply be that "backward-compatible fallback" is a bit too strongly worded; it reads

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. How do we move this or https://phabricator.kde.org/D29136 forward? @ilic As a maintainer, do you have an opinion? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc:

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660620 , @pino wrote: > In D29299#660614 , @kossebau wrote: > > > One does not need to define KDE_INSTALL_LOCALEDIR oneself. One only needs to use

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660614 , @kossebau wrote: > In D29299#660519 , @pino wrote: > > > In D29299#660505 , @kossebau wrote: > > > > > Because

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660519 , @pino wrote: > In D29299#660505 , @kossebau wrote: > > > Because people do strange things, and I prefer to rather not break their card house unless

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660505 , @kossebau wrote: > Because people do strange things, and I prefer to rather not break their card house unless necessary. Again, in which cases? The only way it might change the path is: use ki18n

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Because people do strange things, and I prefer to rather not break their card house unless necessary. Only looking at the undeprecated variable second should be fine, no? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660490 , @kossebau wrote: > D29136 in the current version though changes behaviour by favouring KDE_INSTALL_LOCALEDIR over LOCALE_INSTALL_DIR. Which at least in theory might

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660468 , @pino wrote: > In D29299#660466 , @kossebau wrote: > > > In D29299#660465 , @pino wrote: > > > > > Also,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. In D29299#660466 , @kossebau wrote: > In D29299#660465 , @pino wrote: > > > Also, your patch basically includes D29136 in the case of no

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. In D29299#660453 , @pino wrote: > The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs.

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. > The patch should not require existing users to adapt Yes, that's also what I wrote earlier. Also, your patch basically includes D29136 in the case of no DESTINATION parameter specified, hence my suggestion is: - edit

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. The patch should not require existing users to adapt (though personally I would favour explit DESTINATION args, perhaps a KF6 time thing). That is also why there is no warning emitted in case the DESTINATION is not passed. So nothing should need to be changed

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. > The problem is that ki18n_install() is rarely used manually OK, at least from LXR search it seems a bit more than that: KF packages using ki18n, some extragear stuff, and few Plasma bits. This means that KF packages can switch to that immediately (because of the

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

pino added a comment. The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs. This means that either the majority of the packages will not make use of this, or a

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added reviewers: aacid, ltoscano. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a reviewer: Frameworks. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. Fixes the problem I had with marble, which prompted the creation of https://phabricator.kde.org/D29136. Passing the destination as an parameter seems indeed like a better way, so +1 from me. REPOSITORY R249 KI18n REVISION DETAIL

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Tested now (with DESTINATION passed, without, without & LOCALE_INSTALL_DIR not set), so state: working proposal :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker Cc: kde-frameworks-devel, LeGast00n,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau updated this revision to Diff 81597. kossebau added a comment. - fix typo: ARGS_DESTINATION - small doc improvement REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29299?vs=81590=81597 BRANCH adddestinationargtoki18ninstall REVISION DETAIL

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau added a comment. Have to yet test this properly, uploaded for now as alternative approach to D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker Cc: kde-frameworks-devel,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

kossebau created this revision. kossebau added reviewers: ilic, heikobecker. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY a) LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs,