D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-03 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-03 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by it, as 5.70 is the frameworks dependency for that Plasma release. Frameworks 5.70 just got tagged, so once this lands, it will need to be

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-02 Thread Niccolò Venerandi
niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R242 Plasma Framework (Library) BRANCH heading-only-if-svg-exists (branched from master) REVISION DETAIL https://phabricator.kde.org/D29352 To:

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-01 Thread Filip Fila
filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29352 To: filipf, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-01 Thread Filip Fila
filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We're the only theme with the appropriate heading svgs that make the headers and footers look as they should. All