D29451: KNS: Do not mark entry as installed if install script failed

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2838e55acd17: KNS: Do not mark entry as installed if install script failed (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82180&id=82

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Thank you :D Land away :) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc: kde-framework

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82180. alex added a comment. Use qOverload No problem :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82177&id=82180 BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451 AFFEC

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. (oops, mistakenly marked as accepted, sorry...) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc: kde-fra

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In D29451#665420 , @alex wrote: > Fix connect > > Thanks, I wasn't aware of that until now :-) Same, until a couple of weeks ago :D

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82177. alex added a comment. Fix connect Thanks, I wasn't aware of that until now :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82100&id=82177 BRANCH arcpatch-D29451 REVISION DETAIL https://phabr

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.cpp:355 > QProcess* p = runPostInstallationCommand(installedFiles.size() > == 1 ? installedFiles.first() : targetPath); > -

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82100. alex added a comment. Make lambda inline, capture variables REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82004&id=82100 BRANCH handle_install_script_error (branched from master) REVISION DETAIL ht

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. A bit nitpicky, that first one, the second's more serious (i'd like to avoid that in new code), but looks good otherwise :) INLINE COMMENTS > installation.cpp:355 >

D29451: KNS: Do not mark entry as installed if install script failed

alex edited the summary of this revision. alex edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29451: KNS: Do not mark entry as installed if install script failed

alex created this revision. alex added reviewers: KNewStuff, ngraham, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY If the install script failed/was aborted the entry gets marked as installe