This revision was automatically updated to reflect the committed changes.
Closed by commit R304:9575f2defb27: KNS: Deprecate isRemote method and handle
parse error properly (authored by alex).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Sorted, nicely done :) Makes the code just a touch simpler as well, which is
always good :)
REPOSITORY
R304 KNewStuff
BRANCH
fix_isremote_stuff (branched from master)
REVISION DETAIL
alex marked 2 inline comments as done.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D29455
To: alex, #knewstuff, ngraham, leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
alex updated this revision to Diff 82098.
alex marked an inline comment as done.
alex added a comment.
Typo and error message
If the error message is on two lines they aren't very readable, but
that is an issue for another day :-).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
Apart from these couple of details, it looks pretty good :) (i'd say just fix
and commit, but one of them's a tiny bit larger than just a typo fix ;) )
INLINE COMMENTS
>
alex updated this revision to Diff 82024.
alex retitled this revision from "KNS: Remove isRemote method and handle parse
error properly" to "KNS: Deprecate isRemote method and handle parse error
properly".
alex added a comment.
Make isRemote deprecated
REPOSITORY
R304 KNewStuff
CHANGES
