D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
kossebau closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixbuildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
kossebau added a comment. Building all of KF with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT set, so dropping any deprecated API from the build, serves as a small sanity check to see if the future (like KF6) is well prepared and there is no hidden undeprecated functional dependency on deprecated API. Only backward-compatibel functionality should still rely on any deprecated API. Or otherwise the deprecation should be undone possibly. No oversight over Plasma these days, so cannot tell what parts are still depending on metadata fetched from desktop files via KService. But given such API has been deprecated since KF 5.0 it might be time to complete any missing adaption. So any changes done here are solely based on "it builds without deprecated API used" :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
kossebau created this revision. kossebau added reviewers: Plasma, mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY NO_CHANGELOG REPOSITORY R242 Plasma Framework (Library) BRANCH fixbuildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29600 AFFECTED FILES src/plasma/pluginloader.cpp src/plasma/private/containmentactions_p.h To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
