D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bed09e39fe24: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29610?vs=82750&id

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, at least we'll have moved the code to the right place :-) INLINE COMMENTS > ahmadsamir wrote in file_unix.cpp:1052 > const QByteArray dest1 = "/mnt/fat32/A"; > const QByteArray dest

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:1052 > I'm confused. We want to solve renaming 'a' to 'A' when 'A' does *not* exist. > > QFile::rename will not overwrite an existing file, so it will do nothing if > dest exists. const QByteArray dest1 = "/mnt/f

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:1074 > > if (::rename(_src.data(), _dest.data())) { > if (auto err = execWithElevatedPrivilege(RENAME, {_src, _dest}, > errno)) { Wouldn't it be enough to just call QFile::rename here? The whole idea is: if QFile::re

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29610 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in copyjob.cpp:1965 > Good point, I missed that the original code was checking the file names and > the paths with the same compare() call. > > About /dir/file and /DIR/FILE, the parent dirs is actually one dir since > "dir" and

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added a comment. In D29610#667858 , @dfaure wrote: > OK for now, to fix the unittests. The *real* fix however is to use QFile::rename in kio_file so that this failure to rename doesn't even happen in the first place. > > In this c

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir updated this revision to Diff 82750. ahmadsamir retitled this revision from "[CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming" to "[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems". ahmadsamir edited the summary of this revision. ahmadsami