D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH create-kcmshell-openSystemSettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: ltoscano, cfeck,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 82971. ngraham added a comment. Only open in System Settings or Info Center if systemsettings is installed REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29711?vs=82751=82971 BRANCH

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham added a comment. In D29711#671616 , @mart wrote: > hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not? Yeah Christoph and Luigi brought that up too. Will do.

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Marco Martin
mart added a comment. hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: ltoscano, cfeck,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-14 Thread Nathaniel Graham
ngraham added a comment. In D29711#670503 , @ltoscano wrote: > If the scope of this change is just about Plasma applet, of course systemsettings is going to be around. Yes the scope of this change is purely for Plasma applets; look at

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Luigi Toscano
ltoscano added a comment. In D29711#670470 , @ngraham wrote: > In D29711#670458 , @cfeck wrote: > > > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a comment. In D29711#670458 , @cfeck wrote: > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? Why, is the "I'm using Plasma but I don't have System

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Christoph Feck
cfeck added a comment. Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: cfeck, kde-frameworks-devel,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29716: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29715: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29714: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29713: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Many Plasma applets use `kcmshell.open` to open the appropriate KCM. However