D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Okay :) Hm, need to update 71 to 72 though first, doing now. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping... :) REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-26 Thread Volker Krause
vkrause added a comment. PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. `@deprecated since 5.69 Prefer preferredSize() or trueMinimumSize().`

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. So you propose to also remove the `@deprecated` from the API dox?

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Sune Vuorela
svuorela added a comment. I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. Also, while I might be a unconventional developer, but given this is a tier 1 library, I'm often hand patching the required ECM version to a much lower

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > abstractbarcode.h:69 > */ > +PRISON_DEPRECATED_VERSION_BELATED(5, 71, 5, 69, "Use preferredSize() or > trueMinimumSize()") > QSizeF minimumSize() const; D29573 bringing _BELATED only landed a

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, svuorela, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL