D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González
nibags abandoned this revision.
nibags added a comment.


  This is moved to 
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/2

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González
nibags added a comment.


  I put it all in the README. I also corrected the repository, I had not 
noticed that this repository was already in GitLab!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29795: Add collaboration guide

2020-05-20 Thread Nibaldo González
nibags updated this revision to Diff 83086.
nibags added a comment.


  - Add collaboration guide in the README file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29795?vs=82995&id=83086

BRANCH
  add-collaboration-guide

REVISION DETAIL
  https://phabricator.kde.org/D29795

AFFECTED FILES
  README.md

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29795: Add collaboration guide

2020-05-18 Thread Christoph Cullmann
cullmann added a comment.


  I think this is very good thing to have.
  But perhaps we just should add that to the README.md that is prominently 
shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting
  The README anyways already contains a "Adding unit tests for a syntax 
definition" that could be replaced with this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29795: Add collaboration guide

2020-05-16 Thread Nibaldo González
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add a file with instructions and basic information on how to collaborate in 
the repository.
  
  The idea is to provide information for first-time contributors or who are 
only going to improve or fix some XML file without anything else. This file 
collects the doubts and errors that I have seen that some new contributors have 
had.
  
  Any correction or improvement in the text is appreciated (especially, I would 
appreciate if you could check the wording).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-collaboration-guide

REVISION DETAIL
  https://phabricator.kde.org/D29795

AFFECTED FILES
  COLLABORATE.md

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann