D29811: t/simplify-sending-data-through-socket

2020-05-23 Thread Jiří Paleček
jpalecek abandoned this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek, #frameworks Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread David Edmundson
davidedmundson added a comment. > that would probably mean recompiling most of KDE (Debian has packages for 5.69 only). I will check out your change and see what remains. This isn't a universal rule that always applies, but generally speaking you can just roll back the the frameworks

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread Anthony Fieroni
anthonyfieroni added a comment. > But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE That's not need. Check out master of KCrash, CMakeLists.txt lower kf5 version to match your, compile new patch and test. Then create patch without lower version

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread Jiří Paleček
jpalecek added a comment. In D29811#672534 , @davidedmundson wrote: > Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths. It is 5.69. Yeah, now I can see you got

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread David Edmundson
davidedmundson added a comment. Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths. Also can you check your commit messages, I don't know if it's phab being weird, but they all start with "t/" in the phab UI,

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread Jiří Paleček
jpalecek edited the summary of this revision. jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread Jiří Paleček
jpalecek added a dependent revision: D29812: t/handle-errors-from-socket. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29811 To: jpalecek Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread Jiří Paleček
jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY Simplify sending data through socket, avoid using one large buffer Depends on D29810