D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-06-06 Thread Jiří Paleček
jpalecek added a comment. In D29814#674730 , @dfaure wrote: > This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?" That's because I don't know in which

D29814: Fix segfault on no restart args

2020-06-06 Thread David Faure
dfaure added a comment. This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?" REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc:

D29814: Fix segfault on no restart args

2020-06-06 Thread Jiří Paleček
jpalecek updated this revision to Diff 83232. jpalecek added a comment. Remove contamination from another patch made by the last upload REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29814?vs=83214=83232 BRANCH for-upstream REVISION DETAIL

D29814: Fix segfault on no restart args

2020-06-06 Thread David Faure
dfaure added a comment. This commit seems to include the changes requested in the other review... REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-06-04 Thread Jiří Paleček
jpalecek updated this revision to Diff 83214. jpalecek added a comment. Polished the style as requested REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29814?vs=83138=83214 BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29814

D29814: Fix segfault on no restart args

2020-05-29 Thread David Faure
dfaure added a comment. Can you explain how to trigger this crash in the first place? Which application triggers it? INLINE COMMENTS > jpalecek wrote in kcrash.cpp:272 > Well I was thinking about `resize()`, then found there wasn't any. However, > if we want to be clear, maybe `args = {

D29814: Fix segfault on no restart args

2020-05-27 Thread Jiří Paleček
jpalecek added a comment. In D29814#674013 , @dfaure wrote: > I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled?? > > Also, it sounds like a null check might be

D29814: Fix segfault on no restart args

2020-05-27 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled?? Also, it sounds like a null check might be

D29814: Fix segfault on no restart args

2020-05-26 Thread Jiří Paleček
jpalecek added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-05-23 Thread Jiří Paleček
jpalecek updated this revision to Diff 83138. jpalecek edited the summary of this revision. jpalecek added a dependency: D29810: Don't use the setenv function after fork. jpalecek added a comment. Edited the commit msg, also prune the dependencies I want to abandon REPOSITORY R285 KCrash

D29814: Fix segfault on no restart args

2020-05-17 Thread Jiří Paleček
jpalecek added a reviewer: Frameworks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-05-17 Thread Jiří Paleček
jpalecek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jpalecek requested review of this revision. REVISION SUMMARY When an application is crashing through KCrash, but has no restart argument list, KCrash itself crashes because