D29832: Fix Endianness issue during wallet decryption

chriscz added a comment. Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite a mission getting everyone over to new platforms   REPOSITORY R311 KWallet REVISION DETAIL

D29832: Fix Endianness issue during wallet decryption

ngraham added a reviewer: aacid. ngraham added a comment. Thanks for the patch! FWIW we have moved patch review to GitLab; consider abandoning this and re-submitting it as a merge request at https://invent.kde.org/frameworks/kwallet/-/merge_requests Here's some documentation:

D29832: Fix Endianness issue during wallet decryption

chriscz added a comment. This stack overflow answer has a more exhaustive approach to determining endianness. It may be worth extracting this code into a more appropriate header file though. Also here's the issue on the bugzilla tracker

D29832: Fix Endianness issue during wallet decryption

chriscz created this revision. chriscz added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chriscz requested review of this revision. REVISION SUMMARY Correctly determine endianness on the specific platform using `endian.h' header