This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c61aee80d647: Add a new FindGperf module (authored by
pino).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3830?vs=9502&id=14562#toc
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST
adridg accepted this revision.
adridg added a comment.
I just happened to need a FindGperf in another project today, so I've tested
this in non-ECM settings (adding this plus ECMFindModuleHelpers to that
project's own cmake/) and it works fine on FreeBSD. The docs in the header are
good, too
rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.
Sorry, I haven't had the occasion to test this modification but given our
exchange above this ought to be fine as far as I can tell.
REPOSITORY
R240 Extra CMake Modules
BRANCH
pino-gperf
pino added a comment.
Ping?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
To: pino, #frameworks, #build_system, #windows, kde-mac
Cc: kfunk, rjvbb, adridg
rjvbb added a comment.
In https://phabricator.kde.org/D3830#72701, @pino wrote:
> The full path of gperf is determined using `find_program`, which looks in
`$PATH` -- you can always specify the variable with the full path to force a
custom location.
great, that's exactly what I t
pino added a comment.
In https://phabricator.kde.org/D3830#72696, @rjvbb wrote:
> In https://phabricator.kde.org/D3830#72508, @pino wrote:
>
> > For the input file? Yes.
>
>
> I did mean the gperf executable...!
I don't get what you mean, sorry :/ The full path of gperf i
rjvbb added a comment.
In https://phabricator.kde.org/D3830#72508, @pino wrote:
> For the input file? Yes.
I did mean the gperf executable...!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.or
ltoscano added a dependent revision: D3883: Generate gperf output at build time.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino, #frameworks, #buildsystem, #windo
pino added a comment.
In https://phabricator.kde.org/D3830#72502, @rjvbb wrote:
> You're still determining the location from the path with this new revision,
right?
For the input file? Yes.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
rjvbb added a comment.
You're still determining the location from the path with this new revision,
right?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino, #fr
pino updated this revision to Diff 9502.
pino added a comment.
Typo fix in previous revision.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3830?vs=9499&id=9502
BRANCH
pino-gperf
REVISION DETAIL
https://phabricator.kde.org/D3830
AFFECTED
pino updated this revision to Diff 9499.
pino added a comment.
Restricted Application added projects: Frameworks, Buildsystem.
Use a full path for the output location.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3830?vs=9408&id=9499
BRANCH
pino added a comment.
Cool -- thanks guys for the feedback on FreeBSD/Mac/Windows!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino, #frameworks, #buildsystem,
kfunk added a comment.
Windows: We have working gperf recipe in Craft => we're fine.
QtWebKit already had an (optional) dependency on gperf.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings
rjvbb added a comment.
In https://phabricator.kde.org/D3830#71722, @pino wrote:
> Windows and Mac people: at least from a quick glance, GNU gperf should be
already available on Windows and Mac
I can only speak for 10.9 but indeed, gperf is available in /usr/bin .
REPOSITORY
R24
adridg added a comment.
gperf is also available in the base system for FreeBSD, so this doesn't have
any effects on the build there, either.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/pan
pino added a comment.
Windows and Mac people: at least from a quick glance, GNU gperf should be
already available on Windows and Mac; can you please confirm the new (build
time only) dependency could be acceptable?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.
pino added reviewers: Windows, kde-mac.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino, #frameworks, #kde_buildsystem, #windows, kde-mac
ltoscano added a reviewer: KDE Buildsystem.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino, #frameworks, #kde_buildsystem
pino created this revision.
pino added a reviewer: Frameworks.
REVISION SUMMARY
Add a simple module to look for GNU gperf at build time, providing an
helper macro for adding generations to a list of sources.
gperf will be used to generate the C/C++ sources at build time, instead
of usin
20 matches
Mail list logo
