sars closed this revision.
sars added a comment.
https://commits.kde.org/ktexteditor/1bd9d474763ca891ef67c736398289cfd61bf21f
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5102
To: sars, #kate, #ktexteditor, dhaumann
Cc: mwolff, dhaumann, kwrite-devel,
mwolff added a comment.
Yes, please reserve it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5102
To: sars, #kate, #ktexteditor, dhaumann
Cc: mwolff, dhaumann, kwrite-devel, #frameworks
sars added a comment.
I searched through the kdevelop repo and found marks 8, 21-27 in use + the
"reserved" for Bookmark,... So for KDevelop it looks OK, but we have other
users also.
Should I add "SearchMatch = markType32" to the MarkTypes enum to reserve it?
REPOSITORY
R39
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
If markType32 does not clash with others (e.g. markTypes that are used by
KDevelop), I am fine with this. Could you check this before comitting?
REPOSITORY
R39 KTextEditor
REVISION
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch adds scroll-bar-marks to the matches of "Find all" in the advanced
search bar
TEST PLAN
find all results in
