D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R241:16f69a5d0d55: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD (authored by adridg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=13529=13530

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg updated this revision to Diff 13529. adridg added a comment. - Brain-o on the OpenBSD code - Reduce whitespace changes - Update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=13528=13529 BRANCH arcpatch-D5138 REVISION DETAIL

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg commandeered this revision. adridg edited reviewers, added: tcberner; removed: adridg. REPOSITORY R241 KIO BRANCH arcpatch-D5138 REVISION DETAIL https://phabricator.kde.org/D5138 To: adridg, rakuco, dfaure, arrowdodger, tcberner Cc: aacid, kfunk, emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg updated this revision to Diff 13528. adridg added a comment. Take over the review so as to land it, based on tcberner's comments from april 6th, and Albert's reminder. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12745=13528 BRANCH

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

aacid added a comment. @tcberner Can you mark this as "Request Changes" then so it doens't show up in the list of "this has been approved to land but still noone has commited it yet" list? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To:

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added a comment. We talked about it some more, and think that it is maybe better to not do any cmake magic. #ifdef st_birthtime if (buff.st_birthtime > 0) { entry.insert(KIO::UDSEntry::UDS_CREATION_TIME, buff.st_birthtime); } #endif

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

aacid added a comment. tobias will you commit this? Or are we still waiting for some other approval? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: aacid, kfunk, emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

kfunk added inline comments. INLINE COMMENTS > config-kioslave-file.h.cmake:13 > > +/* Defined if st_birthime is defined */ > +#cmakedefine01 HAVE_ST_BIRTHTIME Note: typo REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger,

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12745. tcberner added a comment. Fix typo. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12744=12745 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED FILES

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12744. tcberner added a comment. Add `#cmakedefine01 HAVE_ST_BIRTHTIME` to `config-kioslave-file.h.cmake` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12743=12744 BRANCH master REVISION DETAIL

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12743. tcberner added a comment. Use cmake to check for `st_birthime`. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12704=12743 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

dfaure added a comment. Ah yes OK, the extraction on Linux is indeed not done in those Qt patches either. Nevermind ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: emmanuelp, #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

emmanuelp added a comment. In https://phabricator.kde.org/D5138#97024, @adridg wrote: > So, Linux, sort out your *stat(2) interfaces first and we'll get back to you. xstat patches have been merged into 4.11 REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg added a comment. Further to the Linux bits: while ext4 and btrfs have the necessary fields, stat(2) doesn't expose them, xstat(2) doesn't exist yet (see LWN from a few years back), and extracting the info using other tools depends on fun stuff like knowing what kind of filesystem the

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

dfaure added a comment. The comment about ctime is still true ;-) For Linux support, I suppose https://codereview.qt-project.org/167049 has what we need. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco,

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

adridg added a comment. Might want to add a comment about "this is the actual inode creation time; support depends on the underlying filesystem (e.g. UFS and ZFS have this information, NFS doesn't)", and change the comment about buff.st_ctime and KDE 2.0. In addition, please insert the

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

arrowdodger accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Feel like implementing it for Linux, too? ;-) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added a comment. F3114620: dolphin2.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: rakuco, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: adridg, arrowdodger. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It seems UDS_CREATION_TIME is never filled at all (as far as I could find in the short time I invested :D ). From the manpage: