apol abandoned this revision.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
REPOSITORY
R325 KAlgebra
REVISION DETAIL
https://phabricator.kde.org/D5197
To: apol, #frameworks
Cc: kde-edu, ltoscano, narvaez, apol
apol updated this revision to Diff 13120.
apol added a comment.
FWIW this works, although it feels weird to include the source dir despite it
not existing
REPOSITORY
R325 KAlgebra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5197?vs=12870=13120
BRANCH
master
REVISION
apol added a comment.
In https://phabricator.kde.org/D5197#97986, @ltoscano wrote:
> I could not properly review the proposed patches which introduces the new
functions (sorry), but do we need the if (EXISTS...) ? Before the changes,
ki18n_install worked also when po/ did not exist.
apol updated this revision to Diff 12870.
apol added a comment.
Just try the directory, no need to make sure it's there
REPOSITORY
R325 KAlgebra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5197?vs=12869=12870
BRANCH
master
REVISION DETAIL
ltoscano added a comment.
I could not properly review the proposed patches which introduces the new
functions (sorry), but do we need the if (EXISTS...) ? Before the changes,
ki18n_install worked also when po/ did not exist.
REPOSITORY
R325 KAlgebra
REVISION DETAIL
apol created this revision.
REVISION SUMMARY
Exemplifies how we'll have to change projects to adopt the changes.
REPOSITORY
R325 KAlgebra
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5197
AFFECTED FILES
CMakeLists.txt
To: apol, #frameworks
