This revision was automatically updated to reflect the committed changes.
Closed by commit R249:4c95ac8bb47f: Allow loading i18n catalogs from arbitrary
locations (authored by davidedmundson).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5208?vs=12962=16509
ilic accepted this revision.
ilic added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> davidedmundson wrote in kcatalog.cpp:124
> I think I still need it.
>
> QHash::value() isn't marked as being atomic so we still need to make sure
> we're not reading at
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> ilic wrote in kcatalog.cpp:124
> Also the lock should be removed, now that only read access is used.
I think I still need it.
QHash::value() isn't marked as being atomic so we still need to
ilic added inline comments.
INLINE COMMENTS
> davidedmundson wrote in klocalizedstringtest.cpp:59
> Pretty sure it's fine. kactivities and kjs use them with no issue.
Well, since no-one else complained either, guess it's ok. Easy to fix later if
someone does complain.
> ilic wrote in
davidedmundson marked 3 inline comments as done.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ilic wrote in klocalizedstringtest.cpp:59
> I think we're not allowed to use initializer lists yet, due to MSVC11 support.
Pretty sure it's
davidedmundson updated this revision to Diff 12962.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
Thanks.
Issues addressed
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5208?vs=12892=12962
BRANCH
master
REVISION
ilic added inline comments.
INLINE COMMENTS
> klocalizedstring.h:558
>
> +static void addDomainLocaleDir(const QByteArray , const QString
> );
> +
Misses docstring. It should be made clear that this method is for "special
purposes" (e.g. plugins and whatnot), and that normal programs
ilic requested changes to this revision.
ilic added a comment.
This revision now requires changes to proceed.
I think it's fine to add this capability, especially given that Gettext
(which Ki18n is an extension of) not only has it, but uses it exclusively (it
does not search through any
davidedmundson updated this revision to Diff 12892.
davidedmundson added a comment.
Missed a file
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5208?vs=12890=12892
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5208
AFFECTED FILES
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
In KDE4, Plasma used to be able to load bundled translations with any
plasmoid downloaded from kde-look.
It used added a KGlobal::dirs()->addResourceDir("locale") at runtime
when
10 matches
Mail list logo
