mgallien added a comment.
In https://phabricator.kde.org/D5417#174323, @dfaure wrote:
> This test seems to fail depending on how QtMultimedia was built. See
failure from the flaska CI, below. Can something be done to detect this?
The extractor is not working well. On Windows, it
dfaure added a comment.
This test seems to fail depending on how QtMultimedia was built. See failure
from the flaska CI, below. Can something be done to detect this?
2017-12-01 19:31:03,939 [output] * Start testing of
QtMultimediaExtractorTest *
2017-12-01 19:31:03,939
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:980d4edf2b52: add an extractor using qtmultimedia
(authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=15454=15461
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
qtmultimedia
REVISION DETAIL
https://phabricator.kde.org/D5417
To: mgallien, #frameworks, dfaure
Cc: dfaure, #frameworks
mgallien added a comment.
Thanks for the review.
The idea of this extractor is to have an extractor not needing taglib (ease
of build, build on platforms other than linux distributions).
QtMultimedia is not extracting a lot of metadata on linux+gstreamer but other
platforms have better
mgallien updated this revision to Diff 15454.
mgallien marked 7 inline comments as done.
mgallien added a comment.
fix issues reported by dfaure
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13840=15454
BRANCH
qtmultimedia
REVISION
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
If this extractor is worse than the taglib one, shouldn't the cmake run issue
a warning about that? Or does it already do so because "taglib not found"?
INLINE COMMENTS
>
mgallien added a comment.
Could somebody review this as that would allow simpler build from source than
building taglib and its dependencies and allow simpler deployment on Windows
and Android ?
Thanks in advance
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5417
To: mgallien, #frameworks
Cc: #frameworks
mgallien updated this revision to Diff 13840.
mgallien added a comment.
fix several issues when testing on Windows with DirectShow Qt backend
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13367=13840
REVISION DETAIL
mgallien updated this revision to Diff 13367.
mgallien added a comment.
update copyright
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13366=13367
BRANCH
qtmultimedia
REVISION DETAIL
https://phabricator.kde.org/D5417
AFFECTED FILES
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
the new extractor is not as good as the taglib built one but depend only
on QtMultimedia
the quality of the extraction depends on
12 matches
Mail list logo
