pedroarthurp abandoned this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5656
To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, gennad,
domson, michaelh, ngraham, bruns, demsking,
dhaumann added a comment.
Do we really need this? Or is this a reject?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5656
To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, hase,
michaelh,
cullmann added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
See e.g. document.cpp:
QVector Document::searchText(const KTextEditor::Range
, const QString , const SearchOptions options) const
{
return
anthonyfieroni added a comment.
Make a protected constructor
Document::Document(DocumentPrivate ) : d(dd) {}
In KateDocument extend DocumentPrivate with KateDocumentPrivate, override
documentReload and give it to base Document
KateDocument(...) : Document(*new
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Please go the non-virtual way, thanks. Or has somebody else a better idea (or
dislikes the whole additional API function).
REPOSITORY
R39 KTextEditor
REVISION DETAIL
cullmann added a comment.
You can add the function as non-virtual one.
Then call the right one of the d pointer, like we do for other new introduced
view stuff:
KTextEditor::Cursor View::maxScrollPosition() const
{
return d->maxScrollPositionInternal();
}
Its bit
pedroarthurp added a comment.
In https://phabricator.kde.org/D5656#106401, @nalvarez wrote:
> I'm pretty sure this breaks ABI by adding a new virtual function... If an
application was compiled against a previous version of KTextEditor and calls
`documentSave()`, when run with a newer
nalvarez added a comment.
I'm pretty sure this breaks ABI by adding a new virtual function... If an
application was compiled against a previous version of KTextEditor and calls
`documentSave()`, when run with a newer KTextEditor version (with this patch)
it may end up calling the new
pedroarthurp added a comment.
https://phabricator.kde.org/D5673 shows a use-case for this feature.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5656
To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kwrite-devel, #frameworks
pedroarthurp added a dependent revision: D5673: Add option to reload a file
without user confirmation after the execution of a external script.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5656
To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc:
pedroarthurp added reviewers: dfaure, brauch, dhaumann, cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5656
To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kwrite-devel, #frameworks
pedroarthurp created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Currently, `KTextEditor::Document::documentReload()` shows a dialog asking
the user if he/she wants to reload a file from
12 matches
Mail list logo
