This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a959e34971f9: ecm_qt_declare_logging_category(): more
unique include guard for header (authored by kossebau).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
kossebau added a comment.
If noone objects or has further comments, will commit this Wednesday, 24th.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5866
To: kossebau, #frameworks, #build_system
Cc: elvisangelaccio
kossebau added a comment.
A different reasoning for why not yet using `#pragma once`: this macro
targets users of projects with at least cmake and Qt. Unless Qt itself does not
use that pragma, let's not risk to screw over people who try to reuse ECM for
some non-mainstream setup, unless we
kossebau added a comment.
Yes, `#pragma once` might be the nicer solution here.
I stayed away from proposing it though, as for one it is not a real standard
by specifications and also by KDE coding traditions.
And I would not like to be the one adding (and thus being responsible) the
elvisangelaccio added a comment.
What about `#pragma once`? Is there some real-world compiler that doesn't
support it?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5866
To: kossebau, #frameworks, #build_system
Cc: elvisangelaccio
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
The old guard was created just from the identifier + _H, which runs the
chance to clash in projects which use an identifier matching the project
name and which also have a class
