elvisangelaccio updated this revision to Diff 14735.
elvisangelaccio added a comment.
- Explicitly ignore QRC paths.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5877?vs=14575=14735
BRANCH
master
REVISION DETAIL
dfaure added a comment.
Yes. KDirWatch doesn't support watching such paths.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5877
To: elvisangelaccio, dfaure
Cc: #frameworks
elvisangelaccio added inline comments.
INLINE COMMENTS
> dfaure wrote in kdirwatch_unittest.cpp:760
> Where does ":/foo" become "." then?
> Why not catch ":/foo" rather than check for "." after some unknown conversion
> somewhere? Feels fragile.
I don't know exactly. So do you think we should
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kdirwatch_unittest.cpp:115
> void stopAndRestart();
> +void bug374075();
>
I prefer more descriptive method names (the bug number as a comment
elvisangelaccio edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5877
To: elvisangelaccio, dfaure
Cc: #frameworks
elvisangelaccio edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5877
To: elvisangelaccio, dfaure
Cc: #frameworks
elvisangelaccio edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5877
To: elvisangelaccio, dfaure
Cc: #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Either "." was explicitly added (in which case we use the absolute path
of the cwd), or it's added as side effect of something
