aacid added a comment.
You want the impossible to remember
Differential Revision: https://phabricator.kde.org/D
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
winterz closed this revision.
winterz added a comment.
committed in
https://phabricator.kde.org/R266:09291a2b3ecf03577b93c6d4cedc28927668e571
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5975
To: winterz, aacid
Cc: aacid, #frameworks
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5975
To: winterz, aacid
Cc: aacid, #frameworks
winterz edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5975
To: winterz
Cc: aacid, #frameworks
aacid added a comment.
In https://phabricator.kde.org/D5975#112013, @winterz wrote:
> Because Hannah told me the script doesn't work on Windows.
Then you need a better commit message :)
Saying "we have bash, let's comment this bash using script" is not what
you're doing.
winterz added a comment.
Because Hannah told me the script doesn't work on Windows.
let's look at validate-svg.sh.
you need a working unix 'find' command (not the WIndows find command) as well
as xmllint for the bash script to work.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
aacid added a comment.
I don't understand, you say it has bash, so why are you commenting out the
bash related code?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5975
To: winterz
Cc: aacid, #frameworks
winterz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The GoW package on Windows has bash. We don't want to find bash on Windows.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
