fvogt added a comment.
In https://phabricator.kde.org/D6002#112526, @dfaure wrote:
> Then isExecutable() is wrong API, it misses the check for the executable
bit. But that's non trivial to fix (check if callers would have the info,
deprecate method and add replacement which takes more in
dfaure added a comment.
Then isExecutable() is wrong API, it misses the check for the executable bit.
But that's non trivial to fix (check if callers would have the info, deprecate
method and add replacement which takes more info as input...).
REPOSITORY
R241 KIO
REVISION DETAIL
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4122b52fee54: Identify PIE binaries
(application/x-sharedlib) as executable files (authored by fvogt).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6002?vs=14928&id=1
dfaure accepted this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6002
To: fvogt, dfaure, aacid
Cc: asturmlechner, #frameworks
fvogt added a comment.
In https://phabricator.kde.org/D6002#112407, @dfaure wrote:
> This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=97226
but indeed, there seems to be no other way.
>
> Maybe add a link to that bug report in one of the uses of x-sharedlib in
yo
fvogt updated this revision to Diff 14928.
fvogt added a comment.
Add a comment referencing the fdo bug report
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6002?vs=14914&id=14928
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6002
AFFECTED
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=97226
but indeed, there seems to be no other way.
Maybe add a link to that bug report in one of the uses of x-share
fvogt created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
x86_64 binaries compiled with PIE are just shared objects with the
executable bit set. Without this patch, kio does not know that they
can be executed as well, causing "kioclient5 exec" to ask f
