mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xdgshell_interface.cpp:40
> the captured "attempt" variable is modified inside the lambda
needs to tack the state as needs to track that only a couple of attempts are
made
REPOSITORY
R127 KWayland
REVISION DETAIL
davidedmundson updated this revision to Diff 19148.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Rename grab signal
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.cpp:40
> what's the idea behind a mutable lambda?
the captured "attempt" variable is modified inside the lambda
REPOSITORY
R127 KWayland
REVISION
graesslin added inline comments.
INLINE COMMENTS
> xdgshell_interface.cpp:40
> +int attempt = 0;
> +connect(pingTimer, ::timeout, q, [this, serial, attempt]()
> mutable {
> +++attempt;
what's the idea behind a mutable lambda?
> xdgshell_interface.h:458
> + */
> +void
davidedmundson updated this revision to Diff 18807.
davidedmundson marked 10 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
added some comments
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
First round of review, client api is done.
INLINE COMMENTS
> registry.h:1275
> + * @param name The name for the removed interface
> + * @since 5.25
> + **/
davidedmundson updated this revision to Diff 17813.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Unbind global
Add a test for transientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
davidedmundson retitled this revision from "WIP: Support XDG v6" to "Support
XDG v6".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
