D6054: Use explicit flag values or explicit constructor instead of nullptr

2017-06-01 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D6054: Use explicit flag values or explicit constructor instead of nullptr

2017-06-01 Thread Friedrich W. H. Kossebau
kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum

D6054: Use explicit flag values or explicit constructor instead of nullptr

2017-06-01 Thread Kevin Funk
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr,

D6054: Use explicit flag values or explicit constructor instead of nullptr

2017-05-31 Thread Friedrich W. H. Kossebau
kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has