This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d2a38d790914: Haskell: Add all language pragmas as
keywords. (authored by arrowdodger).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15982&id=
cullmann accepted this revision.
cullmann added a comment.
Feel free to push ;=)
Thanks for additions!
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann, cullmann
Cc: cullman
arrowdodger updated this revision to Diff 15982.
arrowdodger added a comment.
Updated reference file for autotest as well.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15981&id=15982
BRANCH
master
REVISION DETAIL
https://phabrica
cullmann added a comment.
Hmm, interesting, I would assume you need to update the ref given the input
did change.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: cullman
arrowdodger updated this revision to Diff 15981.
arrowdodger added a comment.
Added autotests. Not sure if .ref file should be updated, as the tests pass
as they are now.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15772&id=15981
BR
cullmann added a comment.
I would say yes.
If you have some more time, you could add an auto-test for it.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: cullmann, dhau
arrowdodger added a comment.
So, can I push this?
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
arrowdodger added a comment.
In https://phabricator.kde.org/D6087#118963, @dhaumann wrote:
> Demo for the highlighting rule - I don't think I can say anything to the
auto completion issue. I am pretty sure it is unrelated to your xml file.
Sure. Pragmas have following form:
dhaumann added a comment.
Demo for the highlighting rule - I don't think I can say anything to the auto
completion issue. I am pretty sure it is unrelated to your xml file.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdo
arrowdodger added a comment.
In https://phabricator.kde.org/D6087#117019, @dhaumann wrote:
> Also: could you provide us with a small demo code so that we can extend our
unit test?
The demo for added highlighting rule, or the problem with autocompletion?
REPOSITORY
R216 Syntax H
arrowdodger updated this revision to Diff 15772.
arrowdodger added a comment.
- Use WordDetect instead of StringDetect for `omport` keyword.
- Pop `Pragma` context on `#-}` string, not newline.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D60
dhaumann added a comment.
@arrowdodger Isn't there a line missing:
+
+
+
<-- This line ?
+
Also, is the lineEndContext #pop or should it rather be #stay?
Please clarify/confirm.
Also: could you provide us with a small demo code so
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I will change the patch slightly and commit: Instead of StringDetect, we
better use WordDetect. Also, we need to increase the version="" number. Besides
that, the patch looks good.
REP
arrowdodger added a comment.
I just found that the same problem exists for `import_keywords` too - when I
type `import qual`, the completion doesn't show up, and deleteting `qual` and
typing it again causes it to show.
So, it seems to be a coding bug.
REPOSITORY
R216 Syntax Highlighti
arrowdodger edited the summary of this revision.
arrowdodger edited the test plan for this revision.
arrowdodger added a reviewer: Framework: Syntax Hightlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightli
arrowdodger created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
AFFECTED FILES
data/syntax/haskell.xml
To: a
16 matches
Mail list logo