jgrulich updated this revision to Diff 15566.
jgrulich added a comment.
Revert unwanted change
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6116?vs=15564=15566
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6116
AFFECTED FILES
jgrulich updated this revision to Diff 15564.
jgrulich added a comment.
Fix enum name and avoid ABI breakage with overriden signal
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6116?vs=15210=15564
BRANCH
master
REVISION DETAIL
jgrulich added a comment.
In https://phabricator.kde.org/D6116#116560, @davidedmundson wrote:
>
> can you find a new signal name and emit both for compatibility?
What would you suggest? I can think of stateChangedWithReason() or
stateChangedWithKnownReason() or
anthonyfieroni added inline comments.
INLINE COMMENTS
> activeconnection.h:77
> +DeviceRealizeFailedReason, /**< Could not create the software device
> link. */
> +DeviceRemoved /** < The device this connection depended on
> disappeared. */
> +};
All others are composed
davidedmundson added a comment.
> There is just one minor problem, with two stateChanged() signals you will
need to specify to which signal you want
> to connect to when using Qt5 syntax for signals/slots and without that you
won't compile current code, i.e. of plasma-nm
I think we're
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There is a new additional StateChanged() signal coming from NetworkManager
with additional reason property so
with that we can now check
jgrulich added a reviewer: lvsouza.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6116
To: jgrulich, lvsouza
Cc: #frameworks
