D6215: Make sure size is final after showEvent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab4aa9909a6: Make sure size is final after showEvent (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6215?vs=15579=15682

D6215: Make sure size is final after showEvent

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6215: Make sure size is final after showEvent

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6215: Make sure size is final after showEvent

mart added a comment. so, on the 5 points: 1. yes, is necessary, resizing windows in their show event is definitely not enough, causes events to arrive to reset to the old geometry in race with the setgeometry done there, if it's the qpa, if it's qwindow, if it's the windowmanager

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent, Ok, great It's somewhat confusing as you have multiple completely independent attempts to

D6215: Make sure size is final after showEvent

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote: > > this will work only when the Dialog' version of setvisible is called, > > So this will break released Plasma? no, it just means that who calls show() or the wrong setVisible() would

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > this will work only when the Dialog' version of setvisible is called, So this will break released Plasma? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas,

D6215: Make sure size is final after showEvent

mart updated this revision to Diff 15579. mart added a comment. hide again mainitem when not visible show it in setVisible, that is before show. this will work only when the Dialog' version of setvisible is called, so must be paid attention when using dialog directly from C++, but

D6215: Make sure size is final after showEvent

mart added a comment. with this, that removes most of the properties depending from visible, i usually get properly sized notifications, tough every now and then the size still fails and a reposition is always visible right after the notification appears https://pastebin.com/ia8nLGiw

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117370, @mart wrote: > it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. in

D6215: Make sure size is final after showEvent

mart added a comment. it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D6215: Make sure size is final after showEvent

mart added a comment. this is how it looks under wayland, keeping the visibility change of the mainitem in plasma-framework and your patch in the notifications applet F3787256: Spectacle.Vd3087.png REPOSITORY R242 Plasma Framework (Library) REVISION

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#116837, @mart wrote: > with patch applied on plasma-framework and notifications applet from master all seems to still work ok. > > so, if i understand correctly, to try with notifiaction applet with your

D6215: Make sure size is final after showEvent

mart added a comment. with patch applied on plasma-framework and notifications applet from master all seems to still work ok. so, if i understand correctly, to try with notifiaction applet with your https://phabricator.kde.org/D6237 on top, and this patch that keeps updating the

D6215: Make sure size is final after showEvent

davidedmundson added a comment. Relavent follow up to the unanswer question from yesterday: why does the implicit height change when we show it It's from some code in NotificationItem.qml ColumnLayout { id: mainLayout anchors { left:

D6215: Make sure size is final after showEvent

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Ok so in summary there's two changes here: - updating our window geometry regardless of whether we're visible or not Makes total sense, there's no

D6215: Make sure size is final after showEvent

mart marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6215: Make sure size is final after showEvent

mart retitled this revision from "Introduce aboutToShow() signal" to "Make sure size is final after showEvent". mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: