This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection
about QAction ownership handling (authored by kossebau).
CHANGED PRIOR TO COMMIT
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kactioncollection.h:325
> *
> + * The ownership of the action object is not transferred. If the action
> is destroyed
> + * it will be removed
kossebau updated this revision to Diff 15611.
kossebau added a comment.
note auto-removal on destroying the action
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6279?vs=15594=15611
BRANCH
apidoxQActionOwnership
REVISION DETAIL
apol added a comment.
Then it would make sense to say what happens if an action is destroyed as
well, no?
Something like `If an action is destroyed will be removed automatically from
the KActionCollection`. Which is what I think it happens but didn't really
check.
REPOSITORY
R263
kossebau created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R263 KXmlGui
BRANCH
apidoxQActionOwnership
REVISION DETAIL
https://phabricator.kde.org/D6279
AFFECTED FILES
src/kactioncollection.h
To: kossebau, #frameworks, dfaure
