graesslin added a comment.
Erm why was this pushed although it was in state changes requested?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6523?vs=16229=16242
REVISION DETAIL
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
please add a test case for the problem.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
mart added a comment.
In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote:
> Same question as before, what happens when we go from a theme with shadows
to a theme without?
I tried to switch back and forth several times between breeze and
keramiek(the theme linked
davidedmundson added a comment.
Same question as before, what happens when we go from a theme with shadows to
a theme without?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if a plasma theme doesn't provide shadow graphics,
the buffer will be a nullptr as would be created
from an
