D6871: Let the indexer check for keywords with leading/trailing spaces

2017-07-24 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9f43abc06b21: indexer checks for leading/trailing 
whitespaces in XML highlighting definitions (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6871?vs=17105=17113

REVISION DETAIL
  https://phabricator.kde.org/D6871

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, vkrause, dhaumann
Cc: #frameworks

D6871: Let the indexer check for keywords with leading/trailing spaces

2017-07-24 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me...

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6871

To: cullmann, vkrause, dhaumann
Cc: #frameworks

D6871: Let the indexer check for keywords with leading/trailing spaces

2017-07-24 Thread Christoph Cullmann 
cullmann added a comment.


  It is no error ATM, as first one needs to cleanup the xml files with 
something like:
  
  perl -pi -e 's@\s*(\S+)\s*@\1@gi' *.xml

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6871

To: cullmann, vkrause, dhaumann
Cc: #frameworks

D6871: Let the indexer check for keywords with leading/trailing spaces

2017-07-24 Thread Christoph Cullmann 
cullmann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Let the indexer check for keywords with leading/trailing spaces, they lead to 
not needed allocs for trimmed() after loading.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6871

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, vkrause, dhaumann
Cc: #frameworks