This revision was automatically updated to reflect the committed changes.
Closed by commit R240:e5301edf1daf: Include a module for finding qml imports as
runtime dependencies (authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7094?v
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
Oh it's gorgeous!
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7094
To: apol, #build_system, #frameworks, sitter
Cc: dfaure, aacid
apol updated this revision to Diff 17922.
apol added a comment.
if no qmlplugindump
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7094?vs=17911&id=17922
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7094
AFFECTED FILES
mod
sitter added inline comments.
INLINE COMMENTS
> apol wrote in ECMFindQMLModule.cmake.in:30
> Doing find_program for now. The right fix would be to change Qt to export the
> `qmlplugindump` target.
You still need to do "something" if qmlplugindump isn't found. Print a
`message(WARNING` and/or `
apol updated this revision to Diff 17911.
apol marked 3 inline comments as done.
apol added a comment.
Address sitter's comments
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7094?vs=17628&id=17911
BRANCH
master
REVISION DETAIL
https://ph
apol added inline comments.
INLINE COMMENTS
> sitter wrote in ECMFindQMLModule.cmake.in:30
> Not sure if we have a common practice for this, but I am thinking this needs
> to have a `find_program()` and give suitable output if qmlplugindump itself
> cannot be found. Pointing the user towards qt
sitter added a comment.
qmlplugindump not being found needs to be handled somehow. Other than that
only minor nitpicks.
(as always I'd also be more confident if it had a test case ;))
INLINE COMMENTS
> ECMFindQMLModule.cmake.in:30
> +
> +execute_process(COMMAND qmlplugindump "@MODULE_NA
apol added a comment.
In https://phabricator.kde.org/D7094#133579, @dfaure wrote:
> Would that help with doing things right for the issue in
https://phabricator.kde.org/D6466 as well?
No, I don't think so. This is mostly for packagers who need to document
dependencies.
REPOSITOR
dfaure added a comment.
Would that help with doing things right for the issue in
https://phabricator.kde.org/D6466 as well?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7094
To: apol, #build_system, #frameworks, sitter
Cc: dfaure, aacid
aacid added a comment.
Guess it would be useful, i'm 68% sure
https://bugs.kde.org/show_bug.cgi?id=383065 is because packaging...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7094
To: apol, #build_system, #frameworks, sitter
Cc: aacid
apol created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
Allows to check if a module is available on the system and sets it as a
runtime dependency.
This is useful for projects so that they can specify their qml dependencies
easily and p
11 matches
Mail list logo
