This revision was automatically updated to reflect the committed changes.
Closed by commit R244:077ef6797eb6: desktopfileparser: Fix non-compliant
key/value parsing. (authored by mpyne).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7170?vs=17913&id=18069
arichardson added a comment.
Looks good to me. Using a regex engine for this seems like overkill but I
guess compared to the I/O overhead of reading the desktop file it shouldn't
matter.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7170
To: mpyne, #framework
mpyne updated this revision to Diff 17913.
mpyne added a comment.
Joins the regex for the Type= line with its use.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7170?vs=17792&id=17913
REVISION DETAIL
https://phabricator.kde.org/D7170
AFFECTED FILES
mpyne marked an inline comment as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7170
To: mpyne, #frameworks, arichardson
Cc: apol
apol added inline comments.
INLINE COMMENTS
> desktopfileparser.cpp:213
> QByteArray type;
> +const static QRegularExpression typeEntryRegex(
> +QStringLiteral("^Type\\s*=\\s*(.*)$"));
Wrong scope?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org
mpyne created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As reported in bug 310674, the Desktop Entry spec says that whitespace
surrounding the = sign that separates the key and value in .desktop files
should be ignored when interpreting the key and val
