This revision was automatically updated to reflect the committed changes.
Closed by commit R241:088a0c67ccdc: make kiod5 an "agent" on Mac (authored by
rjvbb).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7237?vs=18037=18080#toc
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7237
To: rjvbb, #frameworks, dfaure
Cc: kde-mac, dfaure, #frameworks
rjvbb set the repository for this revision to R241 KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7237
To: rjvbb, #frameworks, dfaure
Cc: kde-mac, dfaure, #frameworks
rjvbb updated this revision to Diff 18037.
rjvbb added a comment.
I clearly didn't have my eyes aligned with their sockets ... this should
finally be the complete patch.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7237?vs=17997=18037
REVISION DETAIL
rjvbb added a comment.
In https://phabricator.kde.org/D7237#134438, @dfaure wrote:
> Forgot to git add kiod_agent.mm?
In fact, I see I have a comparable patch for kioslave, but simpler because
AFAICT it won't ever put up a GUI itself.
What would be an appropriate place in
rjvbb updated this revision to Diff 17997.
rjvbb edited the summary of this revision.
rjvbb added a comment.
Forgot a `git add` indeed, as well as a final bit of proofreading.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7237?vs=17981=17997
REVISION DETAIL
rjvbb set the repository for this revision to R241 KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7237
To: rjvbb, #frameworks, dfaure
Cc: kde-mac, dfaure, #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Forgot to git add kiod_agent.mm?
Looks good otherwise.
INLINE COMMENTS
> kiod_main.cpp:132
> +// possibly because of how things have been set up after creating
> +//
rjvbb created this revision.
rjvbb added a project: Frameworks.
REVISION SUMMARY
This introduces a similar change to kiod5 that was already made to other
comparable background applications:
1 the LSUIElement InfoDict key is set, causing the application to run like an
"agent" (without