D7407: audiocd-kio : modernise debugging

2018-11-10 Thread René J . V . Bertin
rjvbb abandoned this revision. rjvbb added a comment. Done by someone else by now. REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7407 To: rjvbb, #frameworks Cc: ltoscano

D7407: audiocd-kio : modernise debugging

2017-08-27 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > CMakeLists.txt:84 > set(kio_audiocd_PART_SRCS audiocd.cpp ) > +ecm_qt_declare_logging_category(kio_audiocd_PART_SRCS HEADER logging.h > IDENTIFIER AUDIOCD CATEGORY_NAME kf5.kio.audiocd) > I would follow a bit more the (unwritten, but used)

D7407: audiocd-kio : modernise debugging

2017-08-19 Thread René J . V . Bertin
rjvbb created this revision. REVISION SUMMARY Modernises the use of debugging classes in audiocd-kio (cf. https://phabricator.kde.org/D7380). I've named the category the way most kioslaves seem to name their categories, using the `kf5` toplevel domain rather than `org.kde` mostly because