D7443: Fix compilation on windows with editorconfig-c-core available

2017-08-22 Thread Kevin Funk 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ab503ec944fe: Fix compilation on windows with 
editorconfig-c-core available (authored by kfunk).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7443?vs=18463&id=18525

REVISION DETAIL
  https://phabricator.kde.org/D7443

AFFECTED FILES
  src/CMakeLists.txt

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7443: Fix compilation on windows with editorconfig-c-core available

2017-08-20 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think this is more correct, just writing the unix libname was no good idea.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7443: Fix compilation on windows with editorconfig-c-core available

2017-08-20 Thread Dominik Haumann 
dhaumann added a comment.


  @cullmann Is this the right fix, or could this also be fixed in 
FindEditorConfig.cmake?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks

D7443: Fix compilation on windows with editorconfig-c-core available

2017-08-20 Thread Kåre Särs 
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  On Windows the library was found during config, but not during compilation 
without the variable EditorConfig_LIBRARIES.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7443

AFFECTED FILES
  src/CMakeLists.txt

To: sars, cullmann, #kate
Cc: kwrite-devel, #frameworks