D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 45043.
ngraham added a comment.


  Rebase on master
  
  Updating D7446 <https://phabricator.kde.org/D7446>: [Places panel] Add a 
Recently Used item by default

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=45040=45043

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Andreas Kainz
andreask added a comment.


  I would suggest to have by default detail view instead of icon view cause 
with detail view it's easier to read the paths.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 45040.
ngraham added a comment.


  - Revamp the whole section

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=42865=45040

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D7446: [Places panel] Add a Recently Used item by default

2018-11-03 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham added a dependency: D15739: [Places panel] Don't show Root by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 42865.
ngraham added a comment.


  Only create "Recently Used" if the protocol is available because `kio-extras` 
is installed

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=42277=42865

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-04 Thread Nathaniel Graham
ngraham added a comment.


  In D7446#336245 , @dfaure wrote:
  
  > I guess the implicit part of the question is "what if kio-extras isn't 
installed ?".
  >  I assume it will lead to a broken item.
  >
  > So this should probably use a check like 
`KProtocolInfo::isKnownProtocol("recentdocuments")`
  
  
  Ah, I see now. Sure, I can do that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread David Faure
dfaure added a comment.


  I guess the implicit part of the question is "what if kio-extras isn't 
installed ?".
  I assume it will lead to a broken item.
  
  So this should probably use a check like 
`KProtocolInfo::isKnownProtocol("recentdocuments")`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham added a comment.


  In D7446#336214 , @davidedmundson 
wrote:
  
  > This is in frameworks, recentdocuments is in kio-extras.
  >
  > Are you sure you can do this?
  
  
  Not sure I catch your meaning. The `recentdocuments:/` kioslave has been 
shipped since forever; this patch just adds it to the Places panel by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread David Edmundson
davidedmundson added a comment.


  This is in frameworks, recentdocuments is in kio-extras.
  
  Are you sure you can do this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham added a comment.


  Ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-25 Thread Sven Mauch
svenmauch added a comment.


  While I wouldn't use it (yet?) I think it's a great addition and would 
benefit a lot of people. I give it a +1, especially if D15739 
 gets approved aswell. ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham edited reviewers, added: VDG, Frameworks; removed: KDE Applications, 
dfaure, emmanuelp.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, 
#kde_applications
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  I'd like to re-submit this patch (now re-based on master) for consideration. 
I put some work into improving the `recentdocuments:/` ioslave in D14893 
 so it's useful now. User requests for this 
feature to be added by default still pop up from time to time, and both GNOME 
and macOS both have this feature in their file browsers and file pickers. I 
think it's relevant and desirable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham retitled this revision from "Add a Recent Documents places item to 
Dolphin and file pickers by default" to "[Places panel] Add a Recently Used 
item by default".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp