D7446: [Places panel] Revamp the Recently Saved section

2019-10-06 Thread Méven Car
meven added a comment. In D7446#542407 , @dfaure wrote: > This commit breaks `kfileplacesmodeltest`, please take a look. > >

D7446: [Places panel] Revamp the Recently Saved section

2019-10-06 Thread David Faure
dfaure added a comment. This commit breaks `kfileplacesmodeltest`, please take a look. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/ REPOSITORY R241

D7446: [Places panel] Revamp the Recently Saved section

2019-10-05 Thread Nathaniel Graham
ngraham added a comment. Wooh! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
meven added a comment. In D7446#542055 , @ngraham wrote: > I think you can go for it. :) Tagging is tomorrow, so please do! Just landed ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e65bf3bc541a: [Places panel] Revamp the Recently Saved section (authored by ngraham, committed by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Nathaniel Graham
ngraham added a comment. I think you can go for it. :) Tagging is tomorrow, so please do! REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-04 Thread Méven Car
meven added a comment. Any new feedback ? REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-03 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-03 Thread Méven Car
meven updated this revision to Diff 67242. meven marked 4 inline comments as done. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67241=67242 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-10-03 Thread Méven Car
meven updated this revision to Diff 67241. meven added a comment. Make bookmarkForUrl const, add context to translate Recent REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67203=67241 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:113 > case KFilePlacesModel::RecentlySavedType: > -m_groupName = i18nc("@item", "Recently Saved"); > +m_groupName = i18nc("@item", "Recent"); > break; this string needs a context, as "recent"

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Méven Car
meven added a comment. Code is ready for review, tests pass @elvisangelaccio @dfaure Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks are only added when KDE_FULL_SESSION is set. D23557 will get merged after this one.

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Méven Car
meven updated this revision to Diff 67203. meven added a comment. Small changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65981=67203 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-10-02 Thread Nathaniel Graham
ngraham added a comment. @meven do you think you could address the final comments and land this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-16 Thread Nathaniel Graham
ngraham added a comment. Ooh, I'm so excited that this will be landing soon! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-13 Thread Elvis Angelaccio
elvisangelaccio added a comment. LGTM besides the inline nitpicks. INLINE COMMENTS > kfileplacesmodeltest.cpp:686 > KBookmark device = root.first(); // The device we'll move is the 6th > bookmark > -for (int i = 0; i < 5; i++) { > +int stop = m_hasRecentlyUsedKio ? 7 : 5; > +

D7446: [Places panel] Revamp the Recently Saved section

2019-09-13 Thread Méven Car
meven updated this revision to Diff 65981. meven added a comment. Update since version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65980=65981 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-09-13 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-13 Thread Méven Car
meven updated this revision to Diff 65980. meven added a comment. add recentlyused:/ bookmarks only in plasma, update following D23742 changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65602=65980 BRANCH

D7446: [Places panel] Revamp the Recently Saved section

2019-09-10 Thread David Faure
dfaure added a comment. The last comment from Méven are the notes from a discussion we had together. In that discussion I realized that the kioslave depends on kactivities-stats, so I'm withdrawing my suggestion to move it to kio, where this dependency isn't wanted. It actually makes

D7446: [Places panel] Revamp the Recently Saved section

2019-09-10 Thread Méven Car
meven added a comment. A plan of action would be : 1. Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used outside ) To improve dolphin and kde apps outside of plasma, make KRecentDocuments a recentlyused file user : 2. Outside of plasma, make

D7446: [Places panel] Revamp the Recently Saved section

2019-09-07 Thread Méven Car
meven updated this revision to Diff 65602. meven added a comment. Use new folder-open-recent for /locations bookmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65519=65602 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Nathaniel Graham
ngraham added a comment. In D7446#526837 , @meven wrote: > But the feature in kactivitymanagerd D23112 , its improvement D23737 and gwenview D23741

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added a dependency: D23760: Create new "Recent folders" icon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Méven Car
meven added a comment. >> Conditionalize the code here with version ifdefs so that people only get both new entries when using kio-extras from 19.12.0 It is already the case : users won't get the new entries without recentlyused:/ installed,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Nathaniel Graham
ngraham added a comment. +1, no objection to that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread David Faure
dfaure added a comment. Sounds to me like KIO depends at runtime on this particular ioslave, so THAT ioslave should move to KIO. Just like I did with KIO trash some time ago. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Luigi Toscano
ltoscano added a comment. In D7446#526741 , @ngraham wrote: > And maybe we should also discuss moving kio-extras to the frameworks release cycle. It's not an app so I'm not sure it makes sense to have it distributed with KDE Applications right

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Nathaniel Graham
ngraham added a comment. And maybe we should also discuss moving kio-extras to the frameworks release cycle. It's not an app so I'm not sure it makes sense to have it distributed with KDE Applications right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To:

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Nathaniel Graham
ngraham added a comment. So we now have a bit of a problem here. The changes to the IOSlave that support files-only and folders-only modes will land in KDE Applications 19.12.0. But this code is in KIO and will land in Frameworks 5.63, which will be released first. We have a few

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Méven Car
meven updated this revision to Diff 65519. meven added a comment. Add two entries to Recent 'Recent Files' and 'Recent Locations' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65199=65519 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Méven Car
meven added a comment. In D7446#526506 , @ngraham wrote: > In D7446#526494 , @meven wrote: > > > It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. >

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. In D7446#526494 , @meven wrote: > It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. > Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic"

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent". Maybe

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. @ngraham you added some dependencies but D23737 and D23741 are not direct dependencies, but rather related fixes. Still, I don't mind leaving them as dependencies. REPOSITORY R241 KIO

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added dependencies: D23742: Add two special cases url recentlyused:/files and recentlyused:/folders, D23737: Extract mimetype from recentlyused.xbel, D23741: Save the Mimetype of opened resources. REPOSITORY R241 KIO REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. In D7446#526304 , @meven wrote: > In D7446#526201 , @ngraham wrote: > > > Fantastic work. That's exactly what I had in mind and it works perfectly! > > > > With those, we

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. In D7446#526201 , @ngraham wrote: > Fantastic work. That's exactly what I had in mind and it works perfectly! > > With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. Fantastic work. That's exactly what I had in mind and it works perfectly! With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent section, and we can get rid of the existing Today entry. That will make this patch

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. In D7446#526039 , @meven wrote: > In D7446#526032 , @ngraham wrote: > > > This works great. > > > > one minor concern I have with the new IOSlave in general is how it shows

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. In D7446#526032 , @ngraham wrote: > This works great. > > one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing.

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This works great. one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing. But I was thinking: how about adding modes that allow

D7446: [Places panel] Revamp the Recently Saved section

2019-09-05 Thread Méven Car
meven added a comment. ping @ngraham any luck testing this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-02 Thread Méven Car
meven updated this revision to Diff 65199. meven added a comment. arc amend REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65198=65199 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-09-02 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-09-02 Thread Méven Car
meven updated this revision to Diff 65198. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65197=65198 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-09-02 Thread Méven Car
meven updated this revision to Diff 65197. meven added a comment. Add recentlyused:/ entry to Recent group to existing users REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65191=65197 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-09-01 Thread Méven Car
meven updated this revision to Diff 65191. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64927=65191 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-09-01 Thread Nathaniel Graham
ngraham added a comment. I think so. It's a very big upgrade, and we're going to be mentioning it in a lot of promo materials. People may get confused and annoyed if they don't see it after reading about it in the release announcement or a U blog post. REPOSITORY R241 KIO REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-08-31 Thread Méven Car
meven added a comment. Should we add this to existing users places settings ? Like we do with `withBaloo` for instance, adding it if it was not added before. INLINE COMMENTS > kfileplacesmodel.cpp:315 > +// Add a Recently Used entry if available (it comes from kio-extras) > +

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Nicolas Fella
nicolasfella removed a reviewer: markg. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Méven Car
meven updated this revision to Diff 64927. meven added a comment. Adapt kio tests to changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64880=64927 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-08-28 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. +1 I don't think @markg'ss change requested status still applies since it was for the ancient version of the patch that I submitted two years ago (!!!). I also think that ultimately we should remove Modified Today and Modified

D7446: [Places panel] Revamp the Recently Saved section

2019-08-28 Thread Méven Car
meven updated this revision to Diff 64880. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=62380=64880 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-08-28 Thread Méven Car
meven added a comment. With D22144 landing this is now ready for prime time ! And thanks to D23112 , this will support history from application using gtk as well (firefox, inkscape...) REPOSITORY R241 KIO

D7446: [Places panel] Revamp the Recently Saved section

2019-08-28 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-08-17 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-08-17 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-08-12 Thread Méven Car
meven added a comment. In D7446#505870 , @ngraham wrote:ut I am all ears for inputs. > Right now by default we only show two: "today" and "last month". We should probably keep it at that, at most; my sense is that even these are very

D7446: [Places panel] Revamp the Recently Saved section

2019-08-02 Thread Nathaniel Graham
ngraham added a comment. In D7446#503575 , @meven wrote: > I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into

D7446: [Places panel] Revamp the Recently Saved section

2019-07-29 Thread Méven Car
meven added a comment. I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into recentlyused:/ ioslave D22144 ) This will

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. meven added a dependency: D22144: Add kio recentlyused:/ to access KactivitytStats data. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik,

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Méven Car
meven added a comment. In D7446#500913 , @ngraham wrote: > With your awesome new `recentlyused:/` ioslave, I find myself wondering if the old `timeline:/` ioslaves even still have value, and if it makes sense to have them in the Places Panel by

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. With your awesome new `recentlyused:/` ioslave, I find myself wondering if the old `timeline:/` ioslaves even still have value, and if it makes sense to have them in the Places Panel by default. REPOSITORY R241 KIO REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Méven Car
meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Méven Car
meven updated this revision to Diff 62380. meven added a comment. Use recentlyused:/ ioslave introduced in D22144 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=45043=62380 BRANCH arcpatch-D7446 REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2019-07-23 Thread Méven Car
meven requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

2019-06-30 Thread Méven Car
meven added a comment. In D7446#486700 , @meven wrote: > I have started D22082 enrolling the plan set in the previous comment. > > Once this task has done enough progress and has landed some of its work, I

D7446: [Places panel] Revamp the Recently Saved section

2019-06-25 Thread Méven Car
meven planned changes to this revision. meven added a comment. I have started D22082 enrolling the plan set in the previous comment. Once this task has done enough progress and has landed some of its work, I will be able to revisit this diff.

D7446: [Places panel] Revamp the Recently Saved section

2019-06-24 Thread Méven Car
meven added a comment. After some discussion, we realized we have three different sets of "recent documents" backends : - recentdocument ioslave using KDirWatch that miss accessed dir and files (used in places) - baloo's timeline ioslave using baloo extractor, that requires baloo but

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:113 > case KFilePlacesModel::RecentlySavedType: > -m_groupName = i18nc("@item", "Recently Saved"); > +m_groupName = i18nc("@item", "Recents"); > break; Rename to "Recent" REPOSITORY R241 KIO

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Méven Car
meven added a comment. In D7446#485714 , @ngraham wrote: > Now that we have creation date support, what do you think about adjusting the timeline to show files that were either created or modified during a given time period? Well

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. Now that we have creation date support, what do you think about adjusting the timeline to show files that were either created or modified during a given time period? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin,

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Méven Car
meven commandeered this revision. meven added a reviewer: ngraham. meven added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:289 > KFilePlacesItem::createSystemBookmark(d->bookmarkManager, > - QStringLiteral("Today"), >

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. "Recent" sounds fine to me. Feel free to commandeer this revision if you'd like to finish it up and handle the tests. These places panel tests are the bane of my existence! :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham,

D7446: [Places panel] Revamp the Recently Saved section

2019-06-23 Thread Méven Car
meven added a comment. In D7446#367532 , @ngraham wrote: > Using "Recently Used" as the section header label presents the following problems: > > - One of the items is named "Recently Used" > - The other items actually do not display a list

D7446: [Places panel] Revamp the Recently Saved section

2019-01-21 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

2018-12-02 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. We need to update `kfileplacesmodeltest` (as well as `placesitemmodeltest` in dolphin). REPOSITORY R241 KIO REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

2018-11-28 Thread David Edmundson
davidedmundson added a comment. Note also that Kickoff's "History" with recent files is /yet another/ completely different data source. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc:

D7446: [Places panel] Revamp the Recently Saved section

2018-11-28 Thread Nathaniel Graham
ngraham added a comment. Using "Recently Used" as the section header label presents the following problems: - One of the items is named "Recently Used" - The other items actually do not display a list of recently used files; they display a list of recently //saved// files. That's

D7446: [Places panel] Revamp the Recently Saved section

2018-11-28 Thread TrickyRicky
trickyricky26 added a comment. I like this change a lot, however I think the Section header should be changed from "Recents" to "Recently Used". I think Recents just sound inelegant and weird REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin,

D7446: [Places panel] Revamp the Recently Saved section

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. Ping! #VDG , #dolphin , or #frameworks folks? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham,

D7446: [Places panel] Revamp the Recently Saved section

2018-11-07 Thread Nathaniel Graham
ngraham added a comment. In D7446#355675 , @andreask wrote: > I would suggest to have by default detail view instead of icon view cause with detail view it's easier to read the paths. That's a good idea, let me see what I can do.

D7446: [Places panel] Revamp the Recently Saved section

2018-11-07 Thread Nathaniel Graham
ngraham retitled this revision from "[Places panel] Add a Recently Used item by default" to "[Places panel] Revamp the Recently Saved section". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL