D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#542407 , @dfaure wrote:
  
  > This commit breaks `kfileplacesmodeltest`, please take a look.
  >
  > 
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/
  
  
  See fix in D24439 
  
  The second failure seems to me sporadic, or at least not related :
  
QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Expected: 
("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", 
"/foreign", "/media/floppy0", "/media/XO-Y4", "/media/cdrom")
QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Got: 
("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", 
"/foreign", "/media/cdrom", "/media/floppy0", "/media/XO-Y4")
FAIL!  : KFilePlacesModelTest::testPlaceGroupHidden() Compared lists differ 
at index 5.
   Actual   (placesUrls()): "/media/cdrom"
   Expected (urls): "/media/floppy0"
   Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.12/autotests/kfileplacesmodeltest.cpp(1091)]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[David Faure]

dfaure added a comment.


  This commit breaks `kfileplacesmodeltest`, please take a look.
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Wooh!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#542055 , @ngraham wrote:
  
  > I think you can go for it. :) Tagging is tomorrow, so please do!
  
  
  Just landed ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e65bf3bc541a: [Places panel] Revamp the Recently Saved 
section (authored by ngraham, committed by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67242=67333

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  I think you can go for it. :) Tagging is tomorrow, so please do!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  Any new feedback ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67242.
meven marked 4 inline comments as done.
meven added a comment.


  Better variable naming

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67241=67242

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67241.
meven added a comment.


  Make bookmarkForUrl const, add context to translate Recent

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=67203=67241

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:113
>  case KFilePlacesModel::RecentlySavedType:
> -m_groupName = i18nc("@item", "Recently Saved");
> +m_groupName = i18nc("@item", "Recent");
>  break;

this string needs a context, as "recent" basically leaves translators clueless 
on what it refers to and/or where it is used

> kfileplacesmodel.h:139
> + */
> +KBookmark bookmarkForUrl(const QUrl );
>  

this method must be const

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: pino, meven, trickyricky26, andreask, huftis, svenmauch, 
kde-frameworks-devel, spoorun, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  Code is ready for review, tests pass @elvisangelaccio @dfaure 
  Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks 
are only added when KDE_FULL_SESSION is set.
  
  D23557  will get merged after this one.
  
  If no-one objects I will merge this in a couple of days.
  Thanks @ngraham for the first accept ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 67203.
meven added a comment.


  Small changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65981=67203

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  @meven do you think you could address the final comments and land this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Ooh, I'm so excited that this will be landing soon!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Elvis Angelaccio]

elvisangelaccio added a comment.


  LGTM besides the inline nitpicks.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:686
>  KBookmark device = root.first(); // The device we'll move is the 6th 
> bookmark
> -for (int i = 0; i < 5; i++) {
> +int stop = m_hasRecentlyUsedKio ? 7 : 5;
> +for (int i = 0; i < stop; i++) {

`const`, and maybe a more descriptive name (`count` or similar?)

> kfileplacesmodeltest.cpp:967
>  // places
> -QTest::newRow("Places - Home") << m_places->index(0, 0)
> +int idx = 0;
> +QTest::newRow("Places - Home") << m_places->index(idx++, 0)

I'd avoid cryptic names. If we can't use `index`, maybe just `i`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65981.
meven added a comment.


  Update since version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65980=65981

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65980.
meven added a comment.


  add recentlyused:/ bookmarks only in plasma, update following D23742 
 changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65602=65980

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[David Faure]

dfaure added a comment.


  The last comment from Méven are the notes from a discussion we had together.
  In that discussion I realized that the kioslave depends on kactivities-stats, 
so I'm withdrawing my suggestion to move it to kio, where this dependency isn't 
wanted.
  It actually makes sense in kio-extras, especially if it gains support for 
non-plasma use cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  A plan of action would be :
  
  1. Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used 
outside )
  
  To improve dolphin and kde apps outside of plasma, make KRecentDocuments a 
recentlyused file user :
  
  2. Outside of plasma, make `recentlyused:/` use recentlyused.xbel as backend
  3. Make KRecentDocumensts use recentlyused.xbel
  
  4. Remove the KDE_FULL_SESSION check added in 1. (Alternatively, not do 1. 
and 4. as 2. and 3. make them not necessary)
  
  5. Kactivities mode without kactivitymanagerd could write data to 
recentlyused.xbel ? Seems not essential as with 3, at least File dialogs will 
mark files opened, only ResourceInstance calls will be added.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65602.
meven added a comment.


  Use new folder-open-recent for /locations bookmark

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65519=65602

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#526837 , @meven wrote:
  
  > But the feature in kactivitymanagerd D23112 
, its improvement D23737 
 and gwenview D23741 
 will only be part of 19.12, making look 
recentlyused:/files somewhat unfinished until 19.12 is released...
  
  
  Actually kactivitymanagerd is on //yet another// release cycle: the Plasma 
one. Happily, your improvements to kactivitymanagerd will land in Plasma 5.17 
which is just around the corner.
  
  > We could backport the gwenview improvement to 19.08.x though.
  
  Done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D23760: Create new "Recent folders" icon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  >> Conditionalize the code here with version ifdefs so that people only get 
both new entries when using kio-extras from 19.12.0
  
  It is already the case : users won't get the new entries without 
recentlyused:/ installed, 
`KProtocolInfo::isKnownProtocol(QStringLiteral("recentlyused")` takes care of 
that without ifdefs (still that is not a perfect solution).
  The code in KIO will stay dormant as a sort of runtime dependency, where as 
long as something is missing it stays almost non-present.
  
  A nice consequence of moving recentlyused:/ to KIO is that it will hit users 
sooner than Applications 19.12 is released consequently.
  
  But the feature in kactivitymanagerd D23112 
, its improvement D23737 
 and gwenview D23741 
 will only be part of 19.12, making look 
recentlyused:/files somewhat unfinished until 19.12 is released...
  We could backport the gwenview improvement to 19.08.x though.
  
  I don't mind moving recentlyused:/ to KIO if we feel it necessary, it is not 
without consequences though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  +1, no objection to that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[David Faure]

dfaure added a comment.


  Sounds to me like KIO depends at runtime on this particular ioslave, so THAT 
ioslave should move to KIO. Just like I did with KIO trash some time ago.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Luigi Toscano]

ltoscano added a comment.


  In D7446#526741 , @ngraham wrote:
  
  > And maybe we should also discuss moving kio-extras to the frameworks 
release cycle. It's not an app so I'm not sure it makes sense to have it 
distributed with KDE Applications right now.
  
  
  It's probably a matter of dependency and guarantee of stability for all the 
librraries included, which may not be trivial
  (I don't want to reopen old discussions right now, but the bundle also ships 
several libraries, despite the name; so the name itself shouldn't be a blocker 
for keeping kio-extras as part of KDE Applications.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  And maybe we should also discuss moving kio-extras to the frameworks release 
cycle. It's not an app so I'm not sure it makes sense to have it distributed 
with KDE Applications right now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  So we now have a bit of a problem here. The changes to the IOSlave that 
support files-only and folders-only modes will land in KDE Applications 
19.12.0. But this code is in KIO and will land in Frameworks 5.63, which will 
be released first.
  
  We have a few options:
  
  - Land the IOSlave changes in KDE Applications 19.08.2
  - Conditionalize the code here with version ifdefs so that people only get 
both new entries when using kio-extras from 19.12.0
  - Wait several months to land this

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65519.
meven added a comment.


  Add two entries to Recent 'Recent Files' and 'Recent Locations'

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65199=65519

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.
meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#526506 , @ngraham wrote:
  
  > In D7446#526494 , @meven wrote:
  >
  > > It would be great to have two different icons for recentlyused:/locations 
and recentlyused:/files.
  > >  Also I am not sure recentlyuserd:/ should use 
"document-open-recent-symbolic" since it is monochrone, the kio declares 
currently "document-open-recent".
  > >  Maybe "folder-temp" for /locations.
  > >  Any suggestion @ngraham ?
  >
  >
  > Good point. We probably need a new icon. `document-open-recent` is fine for 
recentlyused:/files, however for recentlyused:/locations we'll need a 
`folder-open-recent`  that uses the same style, but with a folder as the 
background instead of a file. Ideally both would also have appropriate colorful 
versions for the >22px sizes but that's not a hard requirement.
  >
  > There's plenty of time before the 19.12 release. Please file a bug to 
Breeze | Icons requesting the new icon and mention it in the VDG chatroom. 
Thanks!
  
  
  Thanks
  Done: https://bugs.kde.org/show_bug.cgi?id=411635

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#526494 , @meven wrote:
  
  > It would be great to have two different icons for recentlyused:/locations 
and recentlyused:/files.
  >  Also I am not sure recentlyuserd:/ should use 
"document-open-recent-symbolic" since it is monochrone, the kio declares 
currently "document-open-recent".
  >  Maybe "folder-temp" for /locations.
  >  Any suggestion @ngraham ?
  
  
  Good point. We probably need a new icon. `document-open-recent` is fine for 
recentlyused:/files, however for recentlyused:/locations we'll need a 
`folder-open-recent`  that uses the same style, but with a folder as the 
background instead of a file. Ideally both would also have appropriate colorful 
versions for the >22px sizes but that's not a hard requirement.
  
  There's plenty of time before the 19.12 release. Please file a bug to Breeze 
| Icons requesting the new icon and mention it in the VDG chatroom. Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  It would be great to have two different icons for recentlyused:/locations and 
recentlyused:/files.
  Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" 
since it is monochrone, the kio declares currently "document-open-recent".
  Maybe "folder-temp" for /locations.
  Any suggestion @ngraham ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  @ngraham you added some dependencies but D23737 
 and D23741 
 are not direct dependencies, but rather 
related fixes.
  Still, I don't mind leaving them as dependencies.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added dependencies: D23742: Add two special cases url 
recentlyused:/files and recentlyused:/folders, D23737: Extract mimetype from 
recentlyused.xbel, D23741: Save the Mimetype of opened resources.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#526304 , @meven wrote:
  
  > In D7446#526201 , @ngraham wrote:
  >
  > > Fantastic work. That's exactly what I had in mind and it works perfectly!
  > >
  > > With those, we can have Recent Files and Recent Locations (or maybe 
Recent Folders) in the Recent section, and we can get rid of the existing Today 
entry. That will make this patch //perfect.//
  >
  >
  > +1 for Recent Locations
  >
  > Will replace the entry recentlyused:/ by recentlyused:/files aka "Recent 
files" and recentlyused:/folders aka "Recent Locations".
  
  
  Yay!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#526201 , @ngraham wrote:
  
  > Fantastic work. That's exactly what I had in mind and it works perfectly!
  >
  > With those, we can have Recent Files and Recent Locations (or maybe Recent 
Folders) in the Recent section, and we can get rid of the existing Today entry. 
That will make this patch //perfect.//
  
  
  +1 for Recent Locations
  
  Will replace the entry recentlyused:/ by recentlyused:/files aka "Recent 
files" and recentlyused:/folders aka "Recent Locations".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Fantastic work. That's exactly what I had in mind and it works perfectly!
  
  With those, we can have Recent Files and Recent Locations (or maybe Recent 
Folders) in the Recent section, and we can get rid of the existing Today entry. 
That will make this patch //perfect.//

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#526039 , @meven wrote:
  
  > In D7446#526032 , @ngraham wrote:
  >
  > > This works great.
  > >
  > > one minor concern I have with the new IOSlave in general is how it shows 
both files and folders. For me, the folders are a distraction from the file 
listing. But I was thinking: how about adding modes that allow it to show only 
files or only folders? Like the IOSlave could support `recentlyused:/files` and 
`recentlyused:/folders`, each of which would limit the display to just those 
things. Then under the "Recent" section, we could have "Recent Files" and 
"Recent Locations", which would allow us to remove the useless old "Today" 
entry without any trouble.
  > >
  > > This would provide a better fix for 
https://bugs.kde.org/show_bug.cgi?id=159299.
  >
  >
  > Great suggestions, I will add those to the kio slave.
  
  
  D23742  is here, depends on D23736 
, also two fix to make sure we have mime 
type of files in the database : fix to kactivitymanagerd D23737 
 when getting history from gtk apps and 
D23741  from gwenview

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#526032 , @ngraham wrote:
  
  > This works great.
  >
  > one minor concern I have with the new IOSlave in general is how it shows 
both files and folders. For me, the folders are a distraction from the file 
listing. But I was thinking: how about adding modes that allow it to show only 
files or only folders? Like the IOSlave could support `recentlyused:/files` and 
`recentlyused:/folders`, each of which would limit the display to just those 
things. Then under the "Recent" section, we could have "Recent Files" and 
"Recent Locations", which would allow us to remove the useless old "Today" 
entry without any trouble.
  >
  > This would provide a better fix for 
https://bugs.kde.org/show_bug.cgi?id=159299.
  
  
  Great suggestions, I will add those to the kio slave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This works great.
  
  one minor concern I have with the new IOSlave in general is how it shows both 
files and folders. For me, the folders are a distraction from the file listing. 
But I was thinking: how about adding modes that allow it to show only files or 
only folders? Like the IOSlave could support `recentlyused:/files` and 
`recentlyused:/folders`, each of which would limit the display to just those 
things. Then under the "Recent" section, we could have "Recent Files" and 
"Recent Locations", which would allow us to remove the useless old "Today" 
entry without any trouble.
  
  This would provide a better fix for 
https://bugs.kde.org/show_bug.cgi?id=159299.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  ping @ngraham any luck testing this ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65199.
meven added a comment.


  arc amend

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65198=65199

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65198.
meven added a comment.


  Better variable naming

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65197=65198

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65197.
meven added a comment.


  Add recentlyused:/ entry to Recent group to existing users

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65191=65197

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65191.
meven added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=64927=65191

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  I think so. It's a very big upgrade, and we're going to be mentioning it in a 
lot of promo materials. People may get confused and annoyed if they don't see 
it after reading about it in the release announcement or a U blog post.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  Should we add this to existing users places settings ?
  Like we do with `withBaloo` for instance, adding it if it was not added 
before.

INLINE COMMENTS

> kfileplacesmodel.cpp:315
> +// Add a Recently Used entry if available (it comes from kio-extras)
> +if (KProtocolInfo::isKnownProtocol(QStringLiteral("recentlyused"))) {
> +KFilePlacesItem::createSystemBookmark(d->bookmarkManager,

Should we add this to existing places settings ?
Like we do with `withBaloo` for instance, adding it if it was not added before.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nicolas Fella]

nicolasfella removed a reviewer: markg.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 64927.
meven added a comment.


  Adapt kio tests to changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=64880=64927

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1
  
  I don't think @markg'ss change requested status still applies since it was 
for the ancient version of the patch that I submitted two years ago (!!!).
  
  I also think that ultimately we should remove Modified Today and Modified 
Yesterday because the new one is so much better. But maybe we can have that 
discussion later if you don't agree.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 64880.
meven added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=62380=64880

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  With D22144  landing this is now ready 
for prime time !
  
  And thanks to D23112 , this will support 
history from application using gtk as well (firefox, inkscape...)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#505870 , @ngraham wrote:ut 
I am all ears for inputs.
  
  > Right now by default we only show two: "today" and "last month". We should 
probably keep it at that, at most; my sense is that even these are very 
infrequently used. Sometimes I wonder if they should even be on the placed 
panel by default at all. Especially once your new recentlyused:/ ioslave is 
merged, it's so good that it will obviate the need for the "today" one, at the 
minimum.
  
  
  My proposal was about which default entries to have for the recentlyused:/ 
kio slave.
  With D22717  we have now date filtering 
and with D22775  we will be able to have 
date range filtering in recentlyused:/ and hence we can ask ourselves which are 
the default entries to expose.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, fbampaloukas, alexde, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#503575 , @meven wrote:
  
  > I am working on allow to filter by resource activity date D22717 
 and  D22775 
 (I will add this soonish into 
recentlyused:/ ioslave D22144 )
  >
  > This will allow us to provide similar filters as timeline:/ has : accessed 
today, accessed yesterday...
  >  And perhaps replace timeline:/ default entries in places, at least when 
baloo is turned off.
  >
  > And since I am also adding date range filtering, I ask what date range 
would we want to have ?
  >
  > My proposition would be: today, yesterday, this week (today and the 
previous 6 days) and maybe this month.
  >  No more than 4, for sure, maybe three would be enough.
  >  But I am all ears for inputs.
  
  
  Right now by default we only show two: "today" and "last month". We should 
probably keep it at that, at most; my sense is that even these are very 
infrequently used. Sometimes I wonder if they should even be on the placed 
panel by default at all. Especially once your new recentlyused:/ ioslave is 
merged, it's so good that it will obviate the need for the "today" one, at the 
minimum.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  I am working on allow to filter by resource activity date D22717 
 and  D22775 
 (I will add this soonish into 
recentlyused:/ ioslave D22144 )
  
  This will allow us to provide similar filters as timeline:/ has : accessed 
today, accessed yesterday...
  And perhaps replace timeline:/ default entries in places, at least when baloo 
is turned off.
  
  And since I am also adding date range filtering, I ask what date range would 
we want to have ?
  
  My proposition would be: today, yesterday, this week (today and the previous 
6 days) and maybe this month.
  No more than 4, for sure, maybe three would be enough.
  But I am all ears for inputs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, 
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.
meven edited the test plan for this revision.
meven added a dependency: D22144: Add kio recentlyused:/ to access 
KactivitytStats data.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#500913 , @ngraham wrote:
  
  > With your awesome new `recentlyused:/` ioslave, I find myself wondering if 
the old `timeline:/` ioslaves even still have value, and if it makes sense to 
have them in the Places Panel by default.
  
  
  The today and yesterday, date filters timeline:/ offers are features I would 
like to add to KactivitiesStats.
  But in the meantime we don't have the same features offered so IMO best keep 
it there for now, so that when users have baloo enabled they don't loose this 
feature.
  
  But I agree, the end goal would be to hide timeline:/ in default settings.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  With your awesome new `recentlyused:/` ioslave, I find myself wondering if 
the old `timeline:/` ioslaves even still have value, and if it makes sense to 
have them in the Places Panel by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 62380.
meven added a comment.


  Use recentlyused:/ ioslave introduced in D22144 


REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=45043=62380

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#486700 , @meven wrote:
  
  > I have started D22082  enrolling the 
plan set in the previous comment.
  >
  > Once this task has done enough progress and has landed some of its work, I 
will be able to revisit this diff.
  
  
  Work has moved to the kio-extras repo and is good enough for review D22144 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  I have started D22082  enrolling the plan 
set in the previous comment.
  
  Once this task has done enough progress and has landed some of its work, I 
will be able to revisit this diff.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  After some discussion, we realized we have three different sets of "recent 
documents" backends :
  
  - recentdocument ioslave using KDirWatch that miss accessed dir and files 
(used in places)
  - baloo's timeline ioslave using baloo extractor, that requires baloo but has 
indexing and filtering capatibilities (used in places)
  - kactivities-stats that has activity context, and works for modified or 
accessed files, but that has no ioslave (used in kickoff and kicker)
  
  It appears kactivities-stats has the best feature set compare to 
recentdocuments.
  
  So my plan is to create a kacitity-stats "recentdocuments" ioslave and 
overwrite current recentdocumenst ioslave with it.
  And then used this primarly in dolphin/kfilewidgets with baloo still 
optionally around for its advanced features.
  
  CC @davidedmundson @kbroulik

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:113
>  case KFilePlacesModel::RecentlySavedType:
> -m_groupName = i18nc("@item", "Recently Saved");
> +m_groupName = i18nc("@item", "Recents");
>  break;

Rename to "Recent"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#485714 , @ngraham wrote:
  
  > Now that we have creation date support, what do you think about adjusting 
the timeline to show files that were either created or modified during a given 
time period?
  
  
  Well modified files already includes created files, so that is pretty much 
accomplished.
  And baloo probably does not support file date creation metadata.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Now that we have creation date support, what do you think about adjusting the 
timeline to show files that were either created or modified during a given time 
period?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven commandeered this revision.
meven added a reviewer: ngraham.
meven added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:289
>  KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> -  QStringLiteral("Today"), 
> I18N_NOOP2("KFile System Bookmarks", "Today"),
> +  QStringLiteral("Created 
> Today"), I18N_NOOP2("KFile System Bookmarks", "Today"),
>
> QUrl(QStringLiteral("timeline:/today")),  QStringLiteral("go-jump-today"));

timeline protocol works on modification date, we should change this to 
"Modified Today".
It is a better feature anyway.

> kfileplacesmodel.cpp:292
>  KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> -  QStringLiteral("Yesterday"), 
> I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
> +  QStringLiteral("Created 
> Yesterday"), I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
>
> QUrl(QStringLiteral("timeline:/yesterday")),  
> QStringLiteral("view-calendar-day"));

same here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  "Recent" sounds fine to me. Feel free to commandeer this revision if you'd 
like to finish it up and handle the tests. These places panel tests are the 
bane of my existence! :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#367532 , @ngraham wrote:
  
  > Using "Recently Used" as the section header label presents the following 
problems:
  >
  > - One of the items is named "Recently Used"
  > - The other items actually do not display a list of recently used files; 
they display a list of recently //saved// files.
  >
  >   That's why I was trying to come up with a generic I volunteer myself to 
update the tests.section header label that could feasible encompass both.
  
  
  I think we should use another word than "Recents" like "Recent" singular, 
"Recent files", "Recent Activity" or event "Timeline" perhaps but "Recent" has 
my preference.
  It is a category title usually they are nouns. We can use an adjective but 
since a plural form is weird not to have a noun coming with it.
  
  I volunteer myself to update the tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  We need to update `kfileplacesmodeltest` (as well as `placesitemmodeltest` in 
dolphin).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[David Edmundson]

davidedmundson added a comment.


  Note also that Kickoff's "History" with recent files is /yet another/ 
completely different data source.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Using "Recently Used" as the section header label presents the following 
problems:
  
  - One of the items is named "Recently Used"
  - The other items actually do not display a list of recently used files; they 
display a list of recently //saved// files.
  
  That's why I was trying to come up with a generic section header label that 
could feasible encompass both.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[TrickyRicky]

trickyricky26 added a comment.


  I like this change a lot, however I think the Section header should be 
changed from "Recents" to "Recently Used". I think Recents just sound inelegant 
and weird

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, 
anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, alexde, 
sourabhboss, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Ping! #VDG , #dolphin 
, or #frameworks 
 folks?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#355675 , @andreask wrote:
  
  > I would suggest to have by default detail view instead of icon view cause 
with detail view it's easier to read the paths.
  
  
  That's a good idea, let me see what I can do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham retitled this revision from "[Places panel] Add a Recently Used item by 
default" to "[Places panel] Revamp the Recently Saved section".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov