D7706: Use runtime install prefix instead of compile time install prefix.

habacker marked an inline comment as done. habacker added a comment. In D7706#181225 , @dfaure wrote: > There is a completely different solution: adding to Qt a method that takes a function address and returns the full path to the binary (shared

D7706: Use runtime install prefix instead of compile time install prefix.

dfaure added a comment. QStandardPaths::InstallLocation cannot ever exist, if you mean by that "the install location for KF5" or "the install location for a KF5-based application". How would that work? There could be (at least) 3 different install locations, at least on Unix: one for Qt,

D7706: Use runtime install prefix instead of compile time install prefix.

habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS > dfaure wrote in kinit_win.cpp:205 > That's the Qt install prefix. I guess it matches your KF5 install prefix for > this patch to work, but it doesn't seem like a universal solution. > > Maybe this can

D7706: Use runtime install prefix instead of compile time install prefix.

bcooksley added a comment. This is also a duplicate as mentioned on the other reviews? REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure, ltoscano, bcooksley Cc: dfaure, #frameworks

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added reviewers: ltoscano, bcooksley. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure, ltoscano, bcooksley Cc: dfaure, #frameworks

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added a comment. > If all you need is , you can use QCoreApplication::applicationDirPath(). Did a further look into this stuff and found https://cgit.kde.org/kinit.git/commit/src/kdeinit/kinit_win.cpp?id=6b0ddac715475d7ed36a15f180c755f0f978b7cf. In KDE times there were

D7706: Use runtime install prefix instead of compile time install prefix.

dfaure added a comment. If all you need is , you can use QCoreApplication::applicationDirPath(). REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure Cc: dfaure, #frameworks

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure Cc: dfaure, #frameworks

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added a comment. Does QStandardPaths provide a parameter to retrieve the runtime binary install location ? For example if kdeinit5.exe is located in /bin it should return or if is installed in and there is no 'bin' dir in path it should return ? With

D7706: Use runtime install prefix instead of compile time install prefix.

dfaure added inline comments. INLINE COMMENTS > kinit_win.cpp:205 > +{ > +return QLibraryInfo::location(QLibraryInfo::PrefixPath); > +} That's the Qt install prefix. I guess it matches your KF5 install prefix for this patch to work, but it doesn't seem like a universal solution. Maybe

D7706: Use runtime install prefix instead of compile time install prefix.

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D7706 AFFECTED FILES src/kdeinit/kinit_win.cpp To: habacker Cc: