D7787: Set KPageListView width properly

2017-11-04 Thread Łukasz Wojniłowicz 
wojnilowicz added a comment.


  In https://phabricator.kde.org/D7787#162826, @volkov wrote:
  
  > Could you try to test it without + 5 and with the following change applied?
  >  https://phabricator.kde.org/D8590 ?
  
  
  Without +5 and with https://phabricator.kde.org/D8590 horizontal scrollbar 
appears, so it's not good.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7787

To: wojnilowicz, #frameworks
Cc: volkov, cfeck, tbaumgart, #kmymoney

D7787: Set KPageListView width properly

2017-11-01 Thread Alexander Volkov 
volkov added a comment.


  Could you try to test it without + 5 and with the following change applied?
  https://phabricator.kde.org/D8590 ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7787

To: wojnilowicz, #frameworks
Cc: volkov, cfeck, tbaumgart, #kmymoney

D7787: Set KPageListView width properly

2017-10-15 Thread Łukasz Wojniłowicz 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:56c136985448: Set KPageListView width properly (authored 
by wojnilowicz).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7787?vs=19457=20807

REVISION DETAIL
  https://phabricator.kde.org/D7787

AFFECTED FILES
  src/kpageview_p.cpp

To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymoney

D7787: Set KPageListView width properly

2017-09-12 Thread Łukasz Wojniłowicz 
wojnilowicz added a comment.


  In https://phabricator.kde.org/D7787#145222, @cfeck wrote:
  
  > This is for KWidgetsAddons, right?
  
  
  Yes.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D7787

To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymoney

D7787: Set KPageListView width properly

2017-09-12 Thread Christoph Feck 
cfeck added a comment.


  This is for KWidgetsAddons, right?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D7787

To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymoney

D7787: Set KPageListView width properly

2017-09-12 Thread Łukasz Wojniłowicz 
wojnilowicz created this revision.
wojnilowicz added a project: Frameworks.

REVISION SUMMARY
  sizeHintForIndex returns lower value than sizeHintForColumn and because
  of that horizontal scrollbar appears which is unnecessary.
  Hardcoded 25 value has been changed to `vertical scrollbar width + 5`
  because without 5 horizontal scrollbar still appears.

TEST PLAN
  Before patch
  F3908663: before patch.png 
  
  After patch
  F3908665: after patch.png 

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D7787

AFFECTED FILES
  src/kpageview_p.cpp

To: wojnilowicz, #frameworks
Cc: tbaumgart, #kmymoney