D7864: Basic support for PHP and Python fenced code blocks in Markdown

vkrause added a comment. In D7864#213006 , @dhaumann wrote: > @vkrause Do you already have something in mind, when you say this does not scale? ... No concrete ideas yet, but mainly two observations: - when nesting a language you

D7864: Basic support for PHP and Python fenced code blocks in Markdown

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4f7e020e332d: Basic support for PHP and Python fenced code blocks in Markdown (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. @vkrause Do you already have something in mind, when you say this does not scale? ... REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-blocks (branched from master) REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Fine with me. The approach doesn't scale though, so maybe we need to look into better support for this kind of syntax nesting if we want this for many more languages here (similar

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. This fixes bug https://bugs.kde.org/show_bug.cgi?id=389307 at least partially. More languages such as Ruby etc can still be added. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

cullmann edited reviewers, added: Framework: Syntax Highlighting, vkrause; removed: KTextEditor. cullmann added a comment. +1, Volker, ok to go in? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek, #framework_syntax_highlighting,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek updated this revision to Diff 19631. gszymaszek added a comment. - Removed JavaScript code blocks in Markdown support since it didn’t work - Added test cases for new code blocks in Markdown REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. Could you also extend the test case in https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/test.markdown This way, we can automatically guarantee that we will not break this feature accidentally. REPOSITORY R216 Syntax Highlighting

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek added a subscriber: cfeck. gszymaszek added a comment. Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 ). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch enables syntax highlighting of PHP and Python code blocks in Markdown code. REPOSITORY R216 Syntax Highlighting BRANCH