mart added a comment.
https://phabricator.kde.org/D8060 solves the same problem without new
dependencies
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff
mart added inline comments.
INLINE COMMENTS
> dfaure wrote in kiconloader.h:465
> I guess this is OK as is, so remove the comment (it's not we can change this
> later)
apparently this is giving problems indeed, polkit is now failing to build since
it wasn't explicitly linking to KConfigWidgets
rikmills added a comment.
Since this change, polkit-kde-agent-1 fails to build from source with the
error:
> In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
> from
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
> /usr/include/KF5/K
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:b06e2ecb32a1: expose the colorset for the stylesheet
(authored by mart).
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7891?vs=19935&id=19936
REVISION DETAIL
mart updated this revision to Diff 19935.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
- remove comment
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7891?vs=19787&id=199
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kiconloader.h:465
> +
> +//TODO: do an own colorset enum to not export publicly ConfigWidgets?
> +/**
I guess this is OK as is, so remove the comment (it's not
mart edited the test plan for this revision.
mart added reviewers: Frameworks, Plasma, hein.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart, #frameworks, #plasma, hein
Cc: #frameworks
mart added a reviewer: dfaure.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart, #frameworks, #plasma, hein, dfaure
Cc: #frameworks
mart updated this revision to Diff 19787.
mart added a comment.
- make it work
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7891?vs=19701&id=19787
BRANCH
mart/colorSet
REVISION DETAIL
https://phabricator.kde.org/D7891
AFFECTED FILES
src/CMake
mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
this makes possible having icons loaded with different
colors in different parts of the application, will be needed
by kirigami (which will
mart planned changes to this revision.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart
Cc: #frameworks
11 matches
Mail list logo