D7929: [WIP] Add new Column View option to KDirOperator

Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: kde-frameworks-devel, Coelacanthus, dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, LeGast00n, cblack, michaelh,

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a comment. Ah, what a shame. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

fvogt abandoned this revision. fvogt added a comment. In D7929#251013 , @ngraham wrote: > We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs , and I think

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a comment. We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs , and I think perhaps we should revisit this. I'm very strongly in favor of adding column-based navigation to both `KDirOperator`

D7929: [WIP] Add new Column View option to KDirOperator

dfaure added a comment. In https://phabricator.kde.org/D7929#174598, @fvogt wrote: > - I really dislike the Qt contribution process :-/ As opposed to KDE where it took more than 2 months to get a reply? ;) > - Nobody seems to maintain this upstream (I expect this to be gone

D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#174572, @dfaure wrote: > That would be the kitemviews framework. > > But really, fixing QColumnView in Qt is the much preferred way to go. > It sure sounds harder right now, but think longer term... > In the past, any

D7929: [WIP] Add new Column View option to KDirOperator

dfaure added a comment. That would be the kitemviews framework. But really, fixing QColumnView in Qt is the much preferred way to go. It sure sounds harder right now, but think longer term... In the past, any time we forked something from Qt, we ended up spending even more time

D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#148679, @dhaumann wrote: > Ok. What about licensing? The copied Qt code says LGPLv3 only, while the kio frameworks uses LGPLv2 (and maybe later). Those two licenses are incompatible - we cannot mix LGPLv3 only with an LGPLv2+

D7929: [WIP] Add new Column View option to KDirOperator

dhaumann added a comment. Ok. What about licensing? The copied Qt code says LGPLv3 only, while the kio frameworks uses LGPLv2 (and maybe later). Those two licenses are incompatible - we cannot mix LGPLv3 only with an LGPLv2+ library, except if we make it LGPLv3 only as well. I don't

D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#147784, @ngraham wrote: > I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747 In https://phabricator.kde.org/D7929#147806, @dhaumann wrote: > Since this adds the column view again, how

D7929: [WIP] Add new Column View option to KDirOperator

cfeck added a comment. Exactly because of this confusion (file dialog vs. Dolphin) I would not add columns to the file dialog unless they are also implemented in Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: cfeck, dhaumann,

D7929: [WIP] Add new Column View option to KDirOperator

dhaumann added a comment. Since this adds the column view again, how does this relate to the decision of dropping the column view back in 2012, see comment in this blog: http://ppenz.blogspot.fr/2012/01/dolphin-20-status-update.html?showComment=1325669619833=1 Are the issues of

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a comment. I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: ngraham, elvisangelaccio, lbeltrame, #frameworks

D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#147742, @elvisangelaccio wrote: > I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream? It's not that easy - QColumnView is practically abandoned upstream

D7929: [WIP] Add new Column View option to KDirOperator

elvisangelaccio added a comment. I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not possible to contribute the changes upstream? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: elvisangelaccio, lbeltrame, #frameworks

D7929: [WIP] Add new Column View option to KDirOperator

lbeltrame added a comment. A screenshot before/after (or just after, since it is an addition) would be helpful in this case, since it is a visual change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: lbeltrame, #frameworks

D7929: [WIP] Add new Column View option to KDirOperator

fvogt created this revision. fvogt added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY It uses an imported and improved version of QColumnView for display. KFileItemDelegate got amended with an arrow if used inside KColumnView, to replace the