D8007: popplerextractor: don't try to guess the title if there isn't one.

cfeck added a comment. In D8007#302464 , @szafar wrote: > I use this script to batch rename research papers I download and it works pretty well. Wait, you don't like your PDF's named "ilm1-2007000278.pdf" or "robinson_tr156.pdf"? Tha

D8007: popplerextractor: don't try to guess the title if there isn't one.

szafar added a comment. Just wanted to chime in to say how my workflow depended on this bit of code. I compiled the `tests/dump.cpp` tool and used it as a CLI PDF metadata dumper. I then wrote this script

D8007: popplerextractor: don't try to guess the title if there isn't one.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1491c4a2d9fd: popplerextractor: don't try to guess the title if there isn't one. (authored by flameeyes, committed by ngraham). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://pha

D8007: popplerextractor: don't try to guess the title if there isn't one.

bruns accepted this revision. bruns added a comment. I think this is sensible, to much code for questionable results. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien, bruns Cc: kde-frameworks-devel, #baloo, bruns, micha

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham added a comment. Restricted Application added subscribers: Baloo, kde-frameworks-devel. So... are we landing this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: kde-frameworks-devel, #baloo, bruns, michael

D8007: popplerextractor: don't try to guess the title if there isn't one.

michaelh added a comment. Restricted Application added a project: Baloo. @flameeyes, @mgallien: Any reasons why this is not landed? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: michaelh, anthonyfieroni, mgallien,

D8007: popplerextractor: don't try to guess the title if there isn't one.

anthonyfieroni added a comment. About me it's a good feature after all. It should be simplified e.g. only when title is empty and parse only header of first page. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: ant

D8007: popplerextractor: don't try to guess the title if there isn't one.

mgallien added a comment. @vhanda Thanks a lot to have took time to answer. I really appreciate your help. I took a long time to understand that fixing or modifying the extractors is not enough to get modified data when querying Baloo. I would like to fix that in the future. Do you ha

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. To give some history - Strigi used to do this guessing, and when I implemented KFileMetaData, I decided to do the same. I don't have an opinion on whether it is a good idea or not. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 T

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. > @vhanda do you know if there is something to do to update Baloo database when metadata returned by KFileMetaData are changed even if the file itself did not change ? I'm starting to forget the code base and what all I implemented. But I don't think such a thing

D8007: popplerextractor: don't try to guess the title if there isn't one.

mgallien added subscribers: vhanda, mgallien. mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry for me being late to review your work. I had not noticed it. Thanks for your work. I am all for this change. The code you are rem

D8007: popplerextractor: don't try to guess the title if there isn't one.

aacid resigned from this revision. aacid added a comment. I'm not the one that wrote this code, i have zero input on whether this is a good idea or not or if it should be removed or not All i can do is offer the 1688 pdf files i have lying around to test the difference before and after r

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham edited reviewers, added: aacid; removed: Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, aacid Cc: #frameworks

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham added reviewers: Frameworks, Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, #okular Cc: #frameworks

D8007: popplerextractor: don't try to guess the title if there isn't one.

flameeyes edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes Cc: #frameworks

D8007: popplerextractor: don't try to guess the title if there isn't one.

flameeyes created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 AFFECTED FILES src/extractors/popplerextractor.cpp To: flameeyes Cc: