ngraham closed this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck
Cc: cfeck, #frameworks
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck
Cc: cfeck,
ngraham added a comment.
Submitted a patch for that, too: https://phabricator.kde.org/D8036
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
ngraham added a comment.
Agreed.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
davidedmundson added a comment.
I think it's important that KStandardGuiItem::discard matches
QDialogButtonBox::Discard
You've cited what Qt does, but we override it in kstyle.cpp:374 with
dialog-cancel
If we go with this (and I really don't object) we should adjust KStyle too.
ngraham added a reviewer: davidedmundson.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
cfeck added a comment.
Conflicts with https://phabricator.kde.org/D8024 which I had approved before
I was aware of the bug report.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx
Cc: cfeck, #frameworks
ngraham edited the test plan for this revision.
ngraham added reviewers: Frameworks, VDG, dfaure, rkflx.
ngraham removed a project: Frameworks.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 385158
Use edit-delete icon for buttons that execute destructive discard actions.
This is what Upstream Qt originally had, but we