This revision was automatically updated to reflect the committed changes.
Closed by commit R286:098d62874591: Open files in TagLib extractor readonly
(authored by davidk).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8330?vs=20855=22170
REVISION
davidk added a comment.
In https://phabricator.kde.org/D8330#165813, @ngraham wrote:
> @davidk, I think you have commit rights; do you want to do the honors?
Yes I have commit rights. I'l land it at the weekend. Thanks for your
feedback!
REPOSITORY
R286 KFileMetaData
BRANCH
ngraham added a comment.
@davidk, I think you have commit rights; do you want to do the honors?
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham,
mgallien added a comment.
Yes exactly.
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks
ngraham added a comment.
Do you want to land this?
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks
ngraham added a comment.
Is this ready to land, or do we need some more eyeballs on it first?
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham,
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
If other extractors are already doing that,I guess it is good enough for now.
I guess somebody may one day come up with better error logging (i.e. the user
can discover it).
davidk added reviewers: vhanda, cgiboudeaux, dfaure.
davidk added a comment.
Adding some devs who worked on kfilemetadata in the past.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure
Cc: mgallien,
davidk added a comment.
In https://phabricator.kde.org/D8330#156180, @mgallien wrote:
> I am not sure about the qWarning.
> I would prefer another opinion on that.
Some other extractors also print warnings. I think it's the only way a user
can spot such problems. But let's
mgallien added a comment.
Thanks, I tested it and it works.
I am not sure about the qWarning.
I would prefer another opinion on that.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: mgallien, ngraham, #frameworks
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: ngraham, #frameworks
davidk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is useful if the extractor runs sandboxed, and read-write file access is
denied.
TagLib would retry it readonly, but this saves one
12 matches
Mail list logo
